Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MyClass.|this completion #1208

Conversation

datho7561
Copy link

@datho7561 datho7561 commented Jan 31, 2025

ThisExpression is it's own node, which we will need to handle differently.

Should fix 2 test cases.

@datho7561 datho7561 force-pushed the dom-with-javac-qualified-this-completion branch from 60b4553 to e546daf Compare February 3, 2025 22:25
@datho7561 datho7561 changed the title [WIP] add support for MyClass.|this completion Add support for MyClass.|this completion Feb 3, 2025
@datho7561
Copy link
Author

In this PR, I've added RelevanceUtils.computeRelevanceForInheritance for calculating if RelevanceConstants.R_NON_INHERITED should be used. We will probably need to set DOMCompletionEngine.qualifyingType in a few more cases in order to get the relevance number right in other cases.

@datho7561 datho7561 marked this pull request as ready for review February 3, 2025 22:28
@datho7561 datho7561 force-pushed the dom-with-javac-qualified-this-completion branch from e546daf to 6fa6e9d Compare February 3, 2025 22:29
`ThisExpression` is it's own node, which we will need to handle
differently.

Should fix 2 test cases.

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 force-pushed the dom-with-javac-qualified-this-completion branch from 6fa6e9d to a60b128 Compare February 4, 2025 13:59
@datho7561 datho7561 merged commit b92b0da into eclipse-jdtls:dom-with-javac Feb 4, 2025
6 of 9 checks passed
@datho7561 datho7561 deleted the dom-with-javac-qualified-this-completion branch February 4, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant