Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to add new file extension to make it work with LS. "documentFilters" does not work. #8925

Closed
gazarenkov opened this issue Feb 27, 2018 · 2 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone

Comments

@gazarenkov
Copy link
Contributor

gazarenkov commented Feb 27, 2018

Description

Document Filters, declarative LS configuration ( #7554 ) does not work.

Reproduction Steps

Configure Clang LS as server and add "h" to documentFilters->pathRegexp, like:

 "clangd": {
              "attributes":{
                "internal":"true",
                "type":"ls",
                "config":"{\"id\":\"org.eclipse.che.plugin.cpp\", \"languageIds\":[\"c\", \"cpp\"], \"documentFilters\":[  {  \"languageId\":\"cpp\",  \"pathRegex\":\".*\\\\.(c|cpp|h)\"} ]}"
              },
              "port": "4417",
              "protocol": "tcp"
            } 

It is expected that LS work for h files but it does not.
In fact "documentFilters" does not work at all (adding or removing it changes nothing).
The only way I could make it work is adding fake "h" language to Default Languages.

@gazarenkov gazarenkov added the kind/bug Outline of a bug - must adhere to the bug report template. label Feb 27, 2018
@dkulieshov dkulieshov self-assigned this Mar 14, 2018
@dkulieshov dkulieshov added the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 14, 2018
@gazarenkov gazarenkov added the severity/P1 Has a major impact to usage or development of the system. label Apr 24, 2018
@artaleks9
Copy link
Contributor

Still actual for ver.6.5.0

@tsmaeder
Copy link
Contributor

@artaleks9 is it fixed by the PR that was merged?

@vparfonov vparfonov added this to the 6.6.0 milestone May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

5 participants