Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git preferences for command line #4969

Closed
gorkem opened this issue Apr 28, 2017 · 4 comments · Fixed by #5285
Closed

Git preferences for command line #4969

gorkem opened this issue Apr 28, 2017 · 4 comments · Fixed by #5285
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@gorkem
Copy link
Contributor

gorkem commented Apr 28, 2017

Setting git preferences such as ssh keys should also configure the command line git. Users should be able to do a commit and push identically without doing any additional configuration from UI an terminal.

@ghost
Copy link

ghost commented Apr 29, 2017

Maybe when starting a workspace, we should grab all ssh keys from user prefs and inject them into ~/.ssh so that native git installed in a workspace can use them?

@ghost ghost added the kind/enhancement A feature request - must adhere to the feature request template. label Apr 29, 2017
@sunix
Copy link
Contributor

sunix commented May 2, 2017

problem is when multiple users can access to the workspace, would you let another user to perform a git push with your ssh keys ?

@ghost
Copy link

ghost commented May 2, 2017

Yes, exactly! We already have a solution by launching a script that will get all git prefs and save them into a workspace.

@davidwindell
Copy link
Contributor

@sunix see #4715 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants