Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default path is / and not /projects/ in "Create Quarkus project" wizard #18006

Closed
2 of 3 tasks
l0rd opened this issue Sep 30, 2020 · 16 comments
Closed
2 of 3 tasks

Default path is / and not /projects/ in "Create Quarkus project" wizard #18006

l0rd opened this issue Sep 30, 2020 · 16 comments
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.x (Later, Futur...

Comments

@l0rd
Copy link
Contributor

l0rd commented Sep 30, 2020 •
edited by azatsarynnyy
Loading

Describe the bug

Quarkus plugin welcome page has "Create Quarkus project" button.

image

When clicked, the user has to provide some project details. The last question is about the target folder

image

The problem is that the default target folder is the root folder (/) that is not visible from the IDE.

Che version

che.osio

Steps to reproduce

  1. Open che.openshift.io
  2. Select "Quarkus Tools" among the Getting started samples
  3. Wait for the workspace to start
  4. Open a java file and wait for the "Quarkus Tools for Eclipse Che" welcome page to show up
  5. Click on the "Create Quarkus project" button

Expected behavior

The default target of the Quarkus sample project should be folder '/projects/'.

Sub-tasks
@l0rd l0rd added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 30, 2020
@l0rd l0rd changed the title Default path is "/" and not "/projects/" in Quarkus "create project wizard Default path is / and not /projects/ in "Create Quarkus project" wizard Sep 30, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 30, 2020
@l0rd l0rd mentioned this issue Sep 30, 2020
Closed
16 tasks
@nickboldt nickboldt added area/devfile-registry area/languages Issues related to Language extensions or plugins integration. area/plugin-registry labels Oct 1, 2020
@nickboldt
Copy link
Contributor

nickboldt commented Oct 1, 2020 •
edited
Loading

Presumably the devfile in question is https://github.com/eclipse/che-devfile-registry/blob/master/devfiles/quarkus/devfile.yaml ... or is this a hosted che specific issue? https://github.com/redhat-developer/rh-che

Struggling to understand where you're seeing this button. Steps to repro, @l0rd ?

@sleshchenko sleshchenko added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 5, 2020
@azatsarynnyy
Copy link
Member

It has to be fixed upstream, in vscode-quarkus.
Currently, it opens the dialog without providing an initial directory.

The proposed solution should suit both environments: VS Code and Che.
The first thing we should try is workspace.workspaceFolders API.

@azatsarynnyy azatsarynnyy added this to the 7.21 milestone Oct 8, 2020
@azatsarynnyy azatsarynnyy added area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. and removed area/devfile-registry area/languages Issues related to Language extensions or plugins integration. area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. labels Oct 8, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Oct 8, 2020
Closed
15 tasks
@azatsarynnyy
Copy link
Member

azatsarynnyy commented Oct 12, 2020 •
edited
Loading

vscode-quarkus upstream issue redhat-developer/vscode-quarkus#309 and related PR redhat-developer/vscode-quarkus#310

@azatsarynnyy azatsarynnyy added the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 12, 2020
This was referenced Oct 12, 2020
Closed
Merged
@azatsarynnyy
Copy link
Member

Theia upstream issue eclipse-theia/theia#8640 and related PR eclipse-theia/theia#8641

@azatsarynnyy azatsarynnyy self-assigned this Oct 16, 2020
@azatsarynnyy
Copy link
Member

I've fixed both upstream issues:

Theia patch will go into Che 7.21
To apply Quarkus VS Code extension patch to Che Quarkus Plugin, we need to:
1/ wait for the next extension's release, most likely it will be 1.8.0
2/ upgrade Che Quarkus Plugin to the next extension's version

All Editors related work is done. I'll keep the issue open for Plugins team to finalize it when the next version of Quarkus VS Code extension is released. cc @ericwill
Feel free to close it and open a separate one for an upgrade if needed.

@RomanNikitenko RomanNikitenko mentioned this issue Oct 21, 2020
Merged
@azatsarynnyy
Copy link
Member

I've updated the description with the required sub-tasks.

@azatsarynnyy azatsarynnyy removed the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 27, 2020
@azatsarynnyy azatsarynnyy added this to the 7.26 milestone Jan 21, 2021
@azatsarynnyy
Copy link
Member

reset the milestone to 7.26, as still waiting for Quarkus Tools release

@azatsarynnyy azatsarynnyy modified the milestones: 7.26, 7.27 Feb 11, 2021
@azatsarynnyy azatsarynnyy modified the milestones: 7.27, 7.28 Feb 23, 2021
@azatsarynnyy azatsarynnyy modified the milestones: 7.28, 7.29 Mar 19, 2021
@azatsarynnyy
Copy link
Member

I'm moving it 7.x as it depends on the release of quarkus extension.
The last version was released half a year ago BTW.

@ericwill
Copy link
Contributor

I'm moving it 7.x as it depends on the release of quarkus extension.
The last version was released half a year ago BTW.

We have the latest Quarkus plugin in upstream now: https://github.com/eclipse/che-plugin-registry/blob/master/che-theia-plugins.yaml#L210-L233

@azatsarynnyy
Copy link
Member

yes, but it was released on Sep 21, 2020
and my fix was merged on Oct 15, 2020

@ericwill
Copy link
Contributor

yes, but it was released on Sep 21, 2020
and my fix was merged on Oct 15, 2020

Understood 👍

@azatsarynnyy
Copy link
Member

VS Code Quarkus has been released https://github.com/redhat-developer/vscode-quarkus/releases
So, it's time to upgrade Che Quarkus Plugin. cc @svor

@svor svor removed the sprint/next label Oct 19, 2021
@che-bot
Copy link
Contributor

che-bot commented Apr 17, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2022
@svor
Copy link
Contributor

svor commented Apr 18, 2022

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2022
@azatsarynnyy azatsarynnyy removed their assignment Apr 20, 2022
@che-bot
Copy link
Contributor

che-bot commented Oct 17, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 17, 2022
@che-bot che-bot closed this as completed Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.x (Later, Future, Never)
Development

No branches or pull requests
8 participants
@nickboldt @benoitf @l0rd @svor @azatsarynnyy @sleshchenko @ericwill @che-bot