Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ruby and RoR with Che Theia #15606

Closed
aaqaishtyaq opened this issue Jan 5, 2020 · 8 comments
Closed

Support for Ruby and RoR with Che Theia #15606

aaqaishtyaq opened this issue Jan 5, 2020 · 8 comments
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template. kind/question Questions that haven't been identified as being feature requests or bugs.
Milestone

Comments

@aaqaishtyaq
Copy link

aaqaishtyaq commented Jan 5, 2020

Hi, currently there is no LSP support for Ruby language. Is there any way to run vscode solargraph extension in the sidecar container as a plugin with Eclipse Che 7.x?

@aaqaishtyaq aaqaishtyaq added the kind/question Questions that haven't been identified as being feature requests or bugs. label Jan 5, 2020
@aaqaishtyaq
Copy link
Author

aaqaishtyaq commented Jan 6, 2020

I tried vscode-solargraph extension in a sidecar container with ruby runtime and solargraph gem but it was not able to find the solargraph gem. Ruby syntax highlighting works with vscode-ruby & theia-ruby extension but no LSP.

@aaqaishtyaq aaqaishtyaq changed the title Support for Rails and RoR with Che Theia Support for Ruby and RoR with Che Theia Jan 6, 2020
@tolusha tolusha added area/languages Issues related to Language extensions or plugins integration. area/plugin-broker labels Jan 8, 2020
@mairin
Copy link

mairin commented May 5, 2020

Just putting it out there that ruby support would be nice. It seems an odd omission

@ericwill
Copy link
Contributor

ericwill commented May 5, 2020

Thanks for the input, this is something we can look at in a few sprints.

@ericwill ericwill added kind/enhancement A feature request - must adhere to the feature request template. and removed area/plugin-broker labels May 5, 2020
@liningpan
Copy link

It is possible to change solargraph path in che workspace, and this fixed my problem. You may also try my plugin and sidecar docker image, if you have a self-hosted plugin registry.
You can find my docker image, plugin configuration, and workspace settings in my repository. https://github.com/liningpan/che-ruby-plugin

@ericwill
Copy link
Contributor

It is possible to change solargraph path in che workspace, and this fixed my problem. You may also try my plugin and sidecar docker image, if you have a self-hosted plugin registry.
You can find my docker image, plugin configuration, and workspace settings in my repository. https://github.com/liningpan/che-ruby-plugin

That's awesome! Do you want to contribute your sidecar + plugin configuration to Che? I can create a repo for you in the che-dockerfiles org, where all the other sidecars are located. I'd also be happy to review your PR to add the plugin into the che-plugin-registry.

@liningpan
Copy link

Yes, I would like to contribute my sidecar and plugin.

@ericwill
Copy link
Contributor

Yes, I would like to contribute my sidecar and plugin.

Nice! Please open a PR for your sidecar container here: https://github.com/che-dockerfiles/che-sidecar-ruby

You can look at the che-sidecar-node repo for an idea of what's needed, I've already set up most of the files (automatic build + push to quay.io, PR check, etc.), all that's needed is your Dockerfile, and a VERSION file specifying the version of the extension.

After that, you can open a PR to the che-plugin-registry with your meta.yaml. I'll make sure both PR's get reviewed either by me or someone on my team.

@ericwill
Copy link
Contributor

A big thanks to @liningpan for his contribution -- we now have the Ruby plugin in Che 7.19.

@ericwill ericwill added this to the 7.19 milestone Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template. kind/question Questions that haven't been identified as being feature requests or bugs.
Projects
None yet
Development

No branches or pull requests

5 participants