Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons get_icons function only return a small set of icons #1207

Closed
3 tasks done
linsui opened this issue Sep 9, 2024 · 1 comment
Closed
3 tasks done

icons get_icons function only return a small set of icons #1207

linsui opened this issue Sep 9, 2024 · 1 comment

Comments

@linsui
Copy link

linsui commented Sep 9, 2024

Contributing guidelines

Module(s)

icons

Description

M.get_icons = function()
only returns a small set of icons (148). Can you also add the filetype category so that it will return a larger set of icons (1050)?

Neovim version

0.10.0

Steps to reproduce

devicons_ok, devicons = pcall(require, "nvim-web-devicons")
icon = devicons.get_icons()["lua"]

This doesn't work because lua icon is not in the set.

Expected behavior

No response

Actual behavior

https://github.com/utilyre/barbecue.nvim/blob/main/lua/barbecue/theme.lua#L159 barbecue.nvim can't get the icons.

@linsui linsui added the bug Something isn't working label Sep 9, 2024
@echasnovski echasnovski added mini.icons and removed bug Something isn't working labels Sep 9, 2024
@echasnovski
Copy link
Owner

This is mocking how 'nvim-tree/nvim-web-devicons' does this (i.e. it does not include filetypes).

If anything, 'utilyre/barbecue.nvim' needs to use get_icon here, which is the intended use in this kind of situations. It was changed here, yet I am still not sure why. Or add direct support for 'mini.icons'.

Closing as working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants