Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Python samples #30

Open
kaizu opened this issue Nov 15, 2017 · 3 comments
Open

Refactor Python samples #30

kaizu opened this issue Nov 15, 2017 · 3 comments

Comments

@kaizu
Copy link
Member

kaizu commented Nov 15, 2017

Most samples are moved into Jupyter Notebook. Some of the following Python scripts doesn't works with Python3. Refactor codes or remove if it's deprecated.
https://github.com/ecell/ecell4/tree/master/python/samples

@kaizu
Copy link
Member Author

kaizu commented Nov 15, 2017

All the samples should be ported to https://github.com/ecell/ecell4-notebooks.

kaizu referenced this issue in ecell/ecell4_base Dec 20, 2017
kaizu referenced this issue in ecell/ecell4_base Dec 20, 2017
kaizu referenced this issue in ecell/ecell4_base Dec 20, 2017
@kaizu
Copy link
Member Author

kaizu commented Dec 20, 2017

The following commit accelerates the rule expansion 15 times faster: 5908525

egfr.py with max_itr=8:
Elapsed Time = 0:07:26.454877 -> 0:00:27.418062

@kaizu kaizu self-assigned this Dec 20, 2017
kaizu referenced this issue in ecell/ecell4_base Dec 21, 2017
@kaizu
Copy link
Member Author

kaizu commented Dec 21, 2017

9 times faster now: Elapsed Time = 0:00:27.418062 -> 0:00:02.909375

It takes 14 seconds to generate all the 3749 reactions in egfr.py.

@kaizu kaizu transferred this issue from ecell/ecell4_base Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant