Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using --include-easyblocks-from-pr together with a local easyconfig file fails #3283

Closed
boegel opened this issue Apr 17, 2020 · 2 comments · Fixed by #3486
Closed

using --include-easyblocks-from-pr together with a local easyconfig file fails #3283

boegel opened this issue Apr 17, 2020 · 2 comments · Fixed by #3486
Assignees
Milestone

Comments

@boegel
Copy link
Member

boegel commented Apr 17, 2020

Example:

$ ls ABAQUS-2019.eb
ABAQUS-2019.eb

$ eb ABAQUS-2019.eb --installpath /tmp/$USER --include-easyblocks-from-pr 2034
...
ERROR: Can't find path /tmp/eb-d2fKqd/tmpA9Jiv_/easybuilders/ABAQUS-2019.eb

Using absolute path to easyconfig instead via eb $PWD/AABQUS-2019.eb ... does work...

@migueldiascosta
Copy link
Member

It seems this is actually not only related to --include-easyblocks-from-pr...

For instance, if you mix that local file with files from --from-pr, you get the same behaviour, but it seems it never came up before (?) because that's a weird scenario

The workaround is either to use the absolute path as @boegel mentioned, or to add the folder where the local easyconfig is to the robot path, e.g. in this case with -r .

Now, the reason this happens is that the extract_file method, called from download_repo, changes the working directory (see also #2858), and in fact everything that comes after download_repo seems to rely on that...

@boegel
Copy link
Member Author

boegel commented Oct 25, 2020

@migueldiascosta I'm changing download_repo so it doesn't have the side effect of changing directories anymore in #3486

As far as I can tell, nothing that calls download_repo relies on the changing of directories at all?
The explicit change_dir is just a change we made as a part of #3292 when we changed extract_file...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants