Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix extension fails to load for Seurat #17829

Closed
verdurin opened this issue Apr 28, 2023 · 5 comments · Fixed by #17830
Closed

Matrix extension fails to load for Seurat #17829

verdurin opened this issue Apr 28, 2023 · 5 comments · Fixed by #17830

Comments

@verdurin
Copy link
Member

verdurin commented Apr 28, 2023

Matrix 1.5-1 is now in the Archive, and there needs to be a URL specific for it in the Archive, not for the main enclosing package i.e. Seurat.

@branfosj
Copy link
Member

@branfosj
Copy link
Member

Does that mean

source_urls = [
    'https://cran.r-project.org/src/contrib/Archive/%(name)s',  # package archive
    'https://cran.r-project.org/src/contrib/',  # current version of packages
    'https://cran.freestatistics.org/src/contrib',  # mirror alternative for current packages
]

The first item is expanding %(name)s as Seurat instead of Matrix?

@branfosj
Copy link
Member

And testing that, we see

== fetching files...
  >> download failed: https://cran.r-project.org/src/contrib/Archive/Seurat/Matrix_1.5-1.tar.gz
  >> download failed: https://cran.r-project.org/src/contrib/Matrix_1.5-1.tar.gz
  >> download failed: https://cran.freestatistics.org/src/contrib/Matrix_1.5-1.tar.gz
  >> download failed: https://sources.easybuild.io/s/Seurat/Matrix_1.5-1.tar.gz

In the Seurat easyconfig change:

exts_default_options = {'sources': ['%(name)s_%(version)s.tar.gz']}

to be

exts_default_options = {
    'sources': ['%(name)s_%(version)s.tar.gz'],
    'source_urls': source_urls,
}

@branfosj
Copy link
Member

In fact, we should be setting

exts_default_options = {
    'sources': ['%(name)s_%(version)s.tar.gz'],
    'source_urls': [
        'https://cran.r-project.org/src/contrib/Archive/%(name)s',  # package archive
        'https://cran.r-project.org/src/contrib/',  # current version of packages
        'https://cran.freestatistics.org/src/contrib',  # mirror alternative for current packages
    ],
}

and removing the top level source_urls.

@branfosj
Copy link
Member

branfosj commented Apr 28, 2023

#17830 fixes the Seurat 4.x easyconfigs.

Some method for searching is we need to do this elsewhere is needed. From my quick check this only looks to be impacting the Seurat easyconfigs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants