From d654cfbff7caf6dede9378a830b9c301a1e64072 Mon Sep 17 00:00:00 2001 From: Haytham AbuelFutuh Date: Tue, 14 Apr 2020 13:12:59 -0700 Subject: [PATCH] Log panics (#109) --- flytepropeller/pkg/controller/handler.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/flytepropeller/pkg/controller/handler.go b/flytepropeller/pkg/controller/handler.go index 747ee54e13..a82744bd15 100644 --- a/flytepropeller/pkg/controller/handler.go +++ b/flytepropeller/pkg/controller/handler.go @@ -115,6 +115,7 @@ func (p *Propeller) Handle(ctx context.Context, namespace, name string) error { if r := recover(); r != nil { stack := debug.Stack() err = fmt.Errorf("panic when aborting workflow, Stack: [%s]", string(stack)) + logger.Errorf(ctx, err.Error()) p.metrics.PanicObserved.Inc(ctx) } }() @@ -143,6 +144,7 @@ func (p *Propeller) Handle(ctx context.Context, namespace, name string) error { if r := recover(); r != nil { stack := debug.Stack() err = fmt.Errorf("panic when reconciling workflow, Stack: [%s]", string(stack)) + logger.Errorf(ctx, err.Error()) p.metrics.PanicObserved.Inc(ctx) } }()