Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Boot 2.0 compatibility #62

Closed
otrosien opened this issue Mar 7, 2018 · 8 comments
Closed

Spring Boot 2.0 compatibility #62

otrosien opened this issue Mar 7, 2018 · 8 comments

Comments

@otrosien
Copy link
Contributor

otrosien commented Mar 7, 2018

Epic for work on Spring Boot 2.0 compatibility.

@Izakey
Copy link

Izakey commented Mar 9, 2018

@otrosien Please could you kindly help out with #61 ?

@mduesterhoeft
Copy link
Contributor

@otrosien Just gave it a try and it seems that restdocs-wiremock works fine with spring-boot 2.0.0.RELEASE (which is using spring-restdocs 2.0.0.RELEASE).

@snicoll
Copy link

snicoll commented Jun 21, 2018

Relates to spring-projects/spring-boot#13510

@mduesterhoeft
Copy link
Contributor

@snicoll @otrosien it looks like the starter also works in spring boot 2.0
I could run the examples with spring boot 2.0

See https://github.com/ePages-de/restdocs-wiremock/tree/spring-boot-2.0

@mduesterhoeft
Copy link
Contributor

The question that remains is if we want to move this project to spring boot 2.0 already. @otrosien what do you think?

@otrosien
Copy link
Contributor Author

👍 ... Is epages ready for 2.0?

@snicoll
Copy link

snicoll commented Jul 9, 2018

I am a bit confused. Do you have a CI or something that makes sure it works with the latest 2.x release?

@mduesterhoeft
Copy link
Contributor

mduesterhoeft commented Jul 9, 2018

@snicoll I just created a branch - updated the sample application to use spring boot 2 and ran the tests. That worked fine without touching the actual code of the starter or the spring-restdocs integration.

Travis builds every branch - and also the build for this particular branch is green - https://travis-ci.org/ePages-de/restdocs-wiremock/builds/395420454

I think we will shortly upgrade the project to spring boot 2 completely.

But if you need/expect sth else please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants