Should templates have access to core functions?

[rica-carv]

For instance, the forum_icons_template.php has access to the core functions:

$tp = e107::getParser();
if(deftrue("FONTAWESOME", false)) {

define('IMAGE_e', 					'e');
define('IMAGE_new', 				$tp->toGlyph('fa-star', 'size=2x'));
define('IMAGE_nonew', 				$tp->toGlyph('fa-comment', 'size=2x'));
define('IMAGE_new_small',  			$tp->toGlyph('fa-star'));
define('IMAGE_nonew_small',  		$tp->toGlyph('fa-comment'));
define('IMAGE_new_popular',  		$tp->toGlyph('fa-comments', 'size=2x'));
define('IMAGE_nonew_popular', 		$tp->toGlyph('fa-comments-o', 'size=2x'));
define('IMAGE_new_popular_small',  	$tp->toGlyph('fa-comments'));
define('IMAGE_nonew_popular_small', $tp->toGlyph('fa-comments-o'));
define('IMAGE_sticky',  			$tp->toGlyph('fa-thumb-tack', 'size=2x'));
define('IMAGE_stickyclosed',  		$tp->toGlyph('fa-lock', 'size=2x'));
define('IMAGE_sticky_small', 		$tp->toGlyph('fa-thumb-tack'));
define('IMAGE_stickyclosed_small',  $tp->toGlyph('fa-lock'));
define('IMAGE_announce',  			$tp->toGlyph('fa-bullhorn', 'size=2x'));
define('IMAGE_announce_small',  	$tp->toGlyph('fa-bullhorn'));
define('IMAGE_closed_small',  		$tp->toGlyph('fa-lock'));
define('IMAGE_closed', 				$tp->toGlyph('fa-lock', 'size=2x'));
define('IMAGE_noreplies', 			$tp->toGlyph('fa-comment-o', 'size=2x'));
define('IMAGE_noreplies_small', 	$tp->toGlyph('fa-comment-o'));
define('IMAGE_track', 		        $tp->toGlyph('fa-bell'));
define('IMAGE_untrack', 	        $tp->toGlyph('fa-bell-o'));

Shouldn't this better be donne via the {GLYPH} shortcode???

Just asking, which would be the best practice here....

PS: I think the forum code needs a major overaull, but it's only my opinion....
There's a lot of messy code there, a lot of nested methods, duplicated sc, etc....

[Moc]

Yes, probably this is due to legacy reasons (backwards compatibility mostly). For new templates, definitely do not use this way as done in forum_icons_template.php but instead use {GLYPH}

And yes, the forum code is a huge mess indeed. That's why there's barely any updates.

[rica-carv]

And yes, the forum code is a huge mess indeed. That's why there's barely any updates.

Maybe bit by bit we can change it....

PS: Just a question:

• Should we still keep legacy code? Probably some of it won't work....

I already see a lot of orphan legacy sc inside the code....
Why keep something that probably won't work in PHP 8.x?