-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: using flags as defualts in interactive mode #528
feat: using flags as defualts in interactive mode #528
Conversation
the default config is read from the existing rollapp config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the defaults are the values of the currently existed rollapp if it exists? Isn't this weird? don't we want to have a consistent defaults
thought about it if u think otherwise, for non-interactive mode, it's easy to change |
ye let's keep the defaults constant for now; If a user run init again his current config may be fucked, we don't neccassirily want to use it as default |
…flags-with-interactive-mode-should-set-the-default-value
why only if non interactive? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
when initiailizng a rollapp, the default config is read from the existing rollapp config
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: