Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: using flags as defualts in interactive mode #528

Conversation

mtsitrin
Copy link
Contributor

when initiailizng a rollapp, the default config is read from the existing rollapp config

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

the default config is read from the existing rollapp config
@mtsitrin mtsitrin requested a review from a team as a code owner September 11, 2023 09:45
@mtsitrin mtsitrin linked an issue Sep 11, 2023 that may be closed by this pull request
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the defaults are the values of the currently existed rollapp if it exists? Isn't this weird? don't we want to have a consistent defaults

@mtsitrin
Copy link
Contributor Author

So the defaults are the values of the currently existed rollapp if it exists? Isn't this weird? don't we want to have a consistent defaults

thought about it
we can do either.
IMO, if u have existing roller instance, u could take the values from it as a default

if u think otherwise, for non-interactive mode, it's easy to change

@ItayLevyOfficial
Copy link
Contributor

ye let's keep the defaults constant for now; If a user run init again his current config may be fucked, we don't neccassirily want to use it as default

@ItayLevyOfficial
Copy link
Contributor

why only if non interactive? 🤔

@mtsitrin mtsitrin changed the title feat: reusing old config when re-generatin a rollapp feat: using flags as defualts in interactive mode Sep 12, 2023
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ItayLevyOfficial ItayLevyOfficial merged commit 25f0a12 into main Sep 12, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the mtsitrin/266-passing-flags-with-interactive-mode-should-set-the-default-value branch September 12, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

passing flags with interactive mode, should set the default value
2 participants