Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add roller migrate for Configuration Upgrades #317

Merged
merged 14 commits into from
Jul 31, 2023
Merged

feat: Add roller migrate for Configuration Upgrades #317

merged 14 commits into from
Jul 31, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jul 27, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue Jul 27, 2023 that may be closed by this pull request
Add a roller migrate command to allow a smooth version upgrade #316
Closed
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review July 27, 2023 15:35
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner July 27, 2023 15:35
@ItayLevyOfficial ItayLevyOfficial marked this pull request as draft July 27, 2023 15:36
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review July 30, 2023 07:39
@ItayLevyOfficial ItayLevyOfficial marked this pull request as draft July 30, 2023 07:40
Base automatically changed from itaylevyofficial/310-allow-dymint-metric-server to main July 30, 2023 07:47
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review July 30, 2023 07:50
mtsitrin
mtsitrin requested changes Jul 30, 2023
View reviewed changes
config/toml.go Outdated Show resolved Hide resolved
cmd/migrate/migrate.go Outdated Show resolved Hide resolved
cmd/migrate/migrate.go Outdated Show resolved Hide resolved
cmd/migrate/migrate.go Outdated Show resolved Hide resolved
cmd/migrate/migrate.go Outdated Show resolved Hide resolved
cmd/migrate/migrate.go Outdated Show resolved Hide resolved
mtsitrin
mtsitrin reviewed Jul 31, 2023
View reviewed changes
cmd/migrate/v_0_1_4.go Outdated Show resolved Hide resolved
@mtsitrin mtsitrin merged commit 7890257 into main Jul 31, 2023
@mtsitrin mtsitrin deleted the itaylevyofficial/316-roller-migrate-command branch July 31, 2023 11:08
This was referenced Sep 18, 2024
Closed
Closed
This was referenced Sep 19, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a roller migrate command to allow a smooth version upgrade
2 participants
@ItayLevyOfficial @mtsitrin