Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed json-rpc flag from sequencer start #289

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

mtsitrin
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner July 18, 2023 07:50
@mtsitrin mtsitrin linked an issue Jul 18, 2023 that may be closed by this pull request
@omritoptix
Copy link
Collaborator

I guess will need than to provide explicit guidance in the docs on how to expose it? or do you have any other idea to tackle it?

@mtsitrin mtsitrin force-pushed the mtsitrin/288-rollappd-fails-to-run-with-roller branch from 1b3468a to 8458842 Compare July 19, 2023 09:57
@mtsitrin mtsitrin requested a review from omritoptix July 20, 2023 11:10
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rollappd fails to run with roller
4 participants