Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added gentx_seq call on init #156

Merged
merged 3 commits into from
Jul 2, 2023
Merged

feat: added gentx_seq call on init #156

merged 3 commits into from
Jul 2, 2023

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Jul 2, 2023

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner July 2, 2023 12:32
This was linked to issues Jul 2, 2023
Roller should call gentx_seq when initializing the rollapp #120
Closed
set default keyring-backend type on the rollapp binary #135
Closed
@mtsitrin mtsitrin force-pushed the mtsitrin/120-roller-should-call-gentx_seq-when-initializing-the-rollapp branch from e244fe1 to c89864c Compare July 2, 2023 17:26
@mtsitrin mtsitrin requested a review from ItayLevyOfficial July 2, 2023 17:29
ItayLevyOfficial
ItayLevyOfficial approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mtsitrin mtsitrin merged commit e327098 into main Jul 2, 2023
@mtsitrin mtsitrin deleted the mtsitrin/120-roller-should-call-gentx_seq-when-initializing-the-rollapp branch July 2, 2023 18:22
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItayLevyOfficial ItayLevyOfficial ItayLevyOfficial approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mtsitrin @ItayLevyOfficial