Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chip] Documentation fixes #323

Closed
2 tasks done
Tracked by #321
aweell opened this issue Jun 30, 2021 · 5 comments · Fixed by #329, #514 or #531
Closed
2 tasks done
Tracked by #321

[Chip] Documentation fixes #323

aweell opened this issue Jun 30, 2021 · 5 comments · Fixed by #329, #514 or #531
Assignees
Labels
category: documentation 📓 Improvements or additions to documentation component: chip component task: story ✅ User story
Milestone

Comments

@aweell
Copy link
Collaborator

aweell commented Jun 30, 2021

  • Add iconColor component token in the documentation
Component token Element Token Value
iconColor Icon Hal-Black #000000
iconColor Icon:disabled Hal-Grey-L-60 #999999
  • Change chip height for min-height
@aweell aweell added component: chip component task: story ✅ User story category: documentation 📓 Improvements or additions to documentation labels Jun 30, 2021
@aweell aweell added this to the Release 3.4.0 milestone Jul 2, 2021
@aweell aweell linked a pull request Jul 2, 2021 that will close this issue
@aweell
Copy link
Collaborator Author

aweell commented Jul 2, 2021

Closed with #329

@aweell aweell closed this as completed Jul 2, 2021
@aweell aweell self-assigned this Jul 9, 2021
@aweell
Copy link
Collaborator Author

aweell commented Sep 17, 2021

[3.8.0] Updates

  • Reduce the container padding to 8px
  • Update component images
  • Update component specs

@aweell aweell reopened this Sep 17, 2021
@aweell aweell modified the milestones: Release 3.4.0, Release 3.8.0 Sep 17, 2021
@aweell aweell linked a pull request Sep 20, 2021 that will close this issue
@aweell
Copy link
Collaborator Author

aweell commented Sep 20, 2021

Closed via #514

@aweell aweell closed this as completed Sep 20, 2021
@aweell
Copy link
Collaborator Author

aweell commented Sep 21, 2021

[3.9.0] Updates

  • Fix chip height spec

@aweell aweell reopened this Sep 21, 2021
@aweell aweell modified the milestones: Release 3.8.0, Release 3.9.0 Sep 21, 2021
@aweell aweell linked a pull request Sep 21, 2021 that will close this issue
@aweell
Copy link
Collaborator Author

aweell commented Sep 21, 2021

Closed via #531

@aweell aweell closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment