Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Toggle group] Component review #452

Closed
5 tasks done
aweell opened this issue Nov 15, 2021 · 0 comments · Fixed by #464
Closed
5 tasks done

[Toggle group] Component review #452

aweell opened this issue Nov 15, 2021 · 0 comments · Fixed by #464
Labels
priority: high

Comments

@aweell
Copy link
Collaborator

aweell commented Nov 15, 2021 •
edited by aidamag
Loading

Toggle component review

Changes on the specs can be found on: Toggle group documentation draft

Updated component specs

  • Add toggle group container element
  • Review button element border-radius (from 0px to 0.25rem / 4px)
  • Add the possibility to have label and icon simultaneously
  • Introduce a 0.25rem / 4px gutter between toggle buttons
  • Add component label and helper text

Any fixes needed in the component documentation can be submitted to the component review PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 452 dxc-technology/halstack-angular
2 participants
@aidamag @aweell