Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images Not Copied on --stage=prod #144

Open
jboothe opened this issue Apr 9, 2015 · 2 comments
Open

Images Not Copied on --stage=prod #144

jboothe opened this issue Apr 9, 2015 · 2 comments
Labels

Comments

@jboothe
Copy link

jboothe commented Apr 9, 2015

When running gulp --stage=prod the images and image folder do not get copied over to the build directory although terminal output shows images finishing:

[01:37:51] gulp-imagemin: Minified 29 images (saved 57.88 kB - 6%)
[01:37:51] Finished 'images' after 5.04 s

I'm also getting the following error in the browser console:
Error: [jqLite:onargs] jqLite#on() does not support the selectororeventData parameters

Is there an issue with svg's? I also get a giant block of base64 output in the terminal during bowerCopy. Below is just an excerpt.

[01:37:52] Starting 'bowerCopy'...
angular-ui-grid/ui-grid.eot
angular-ui-grid/ui-grid.eot#iefix
angular-ui-grid/ui-grid.woff
angular-ui-grid/ui-grid.ttf?
angular-ui-grid/ui-grid.svg?#ui-grid
/c/dev/iCheer/Dashboard-201-Poly/bower_components/angularjs-toaster/toaster.cssdata:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABgAAAAs4c6QAAA ...
/c/dev/iCheer/Dashboard-201-Poly/bower_components/angularjs-toaster/toaster.cssdata:image/gif;base64,R0lGODlhIAAgAIQAAAQCBISGhMzKzERCROTm5CQHx...
/c/dev/iCheer/Dashboard-201-Poly/bower_components/ng-grid/ng-grid.cssdata:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYA...

A dev gulp build runs perfectly with no console errors. I'm using 0.8.3 with node 0.12.2.

And if I haven't mentioned it before, I've been using your gen since 10/2014 and loving it!!

@jboothe
Copy link
Author

jboothe commented Apr 9, 2015

I've narrowed the image copy issue to the deleteTemplates task. I noticed you have '!' + config.buildImages in there twice. Deleting one of them still made no difference. It's ignoring your ignore statements. So for the time, I'm bypassing deleteTemplates and starting the build at copyTemplates.

I still trying to figure out the base64 garbage with angularjs-toaster/toaster.cssdata:image/png;base64.... Seems the bowerAssets task is choking on something in the bower_components/angularjs-toaster package. Is this just a poorly designed bower package?

I'm not familiar with how bower packages are processed by gulp so any insight / tips on how I might debug this is appreciated. Thanks.

@dustinspecker
Copy link
Owner

Oops at the base64 output. I have a console.log at

that can be removed.

Hmm. SVGs should get copied over. I'll try to do some experimenting with that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants