Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Update to Node 22 and Resolve Deprecation Warnings #2543

Open
nortonandreev opened this issue Oct 1, 2024 · 0 comments
Open
Assignees
Labels
module:web-wallet Issues related to web-wallet module

Comments

@nortonandreev
Copy link
Contributor

Description:

To accelerate the development of the web-wallet for w3sper, I have updated the engine requirements to Node 22 (which will be the next LTS version) due to web socket compatibility. While there might be a way to use compatible web sockets in Node 20, I didn’t have the time to explore this further due to other priorities. We can revisit this later if needed.

Immediate Actions:

  • We need a PR to update the CI configuration to use Node 22. This should be straightforward.

Problem:

  • Node 22 introduces a new feature that floods our tests with deprecation warnings (in red), making it difficult to troubleshoot issues. These warnings are caused by deprecated modules, particularly punycode, which is used by many other modules.

Potential Solution:

  • Upon investigation, switching to punycode.js seems to eliminate the warnings (see issue).

  • I attempted to use the override field in package.json, but I wasn’t successful. I’m unsure whether this is due to an error on my part or if we should address it through some Vite/Rollup config adjustment (e.g., adding a "module alias").

Next Steps:

  • Investigate and implement a solution to replace punycode with punycode.js to eliminate the warnings.
  • Consider if any Vite/Rollup config tweaks are required to make this change seamless.
@nortonandreev nortonandreev self-assigned this Oct 1, 2024
@nortonandreev nortonandreev added the module:web-wallet Issues related to web-wallet module label Oct 1, 2024
@nortonandreev nortonandreev changed the title web-wallet: Update CI for Node 22 and Resolve Deprecation Warnings Related to punycode web-wallet: Update CI for Node 22 and Resolve Deprecation Warnings Oct 1, 2024
@nortonandreev nortonandreev changed the title web-wallet: Update CI for Node 22 and Resolve Deprecation Warnings web-wallet: Update to Node 22 and Resolve Deprecation Warnings Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:web-wallet Issues related to web-wallet module
Projects
None yet
Development

No branches or pull requests

1 participant