Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Define and Implement Consistent Card Component Guidelines #2285

Closed
nortonandreev opened this issue Sep 6, 2024 · 1 comment · Fixed by #2354
Closed

web-wallet: Define and Implement Consistent Card Component Guidelines #2285

nortonandreev opened this issue Sep 6, 2024 · 1 comment · Fixed by #2354
Assignees
Labels
fix:bug Something isn't working module:web-wallet Issues related to web-wallet module need:specs Call for participation: specs are requested to fix this issue

Comments

@nortonandreev
Copy link
Contributor

nortonandreev commented Sep 6, 2024

Description:

Recent updates to the Wallet's UI have introduced several inconsistencies and regressions in the use of the Card component. To address these issues, we need to establish clear guidelines for the following:

  • Icon Placement: Define rules for when an icon should appear on the left side versus the right side of the card.
  • Icon Usage: Establish criteria for when an icon should be included on a card and when it should be omitted.
  • Color Usage: Set rules for color usage, specifically when to use blue versus the default color.
  • Switch Appearance: Standardize the appearance of cards that include a switch.

Once these guidelines are defined, we need to ensure that both the design and implementation strictly adhere to them to maintain consistency throughout the UI.

Some examples of currently broken implementation:
Screenshot 2024-09-03 at 19 11 07
Screenshot 2024-09-03 at 19 11 01

@nortonandreev nortonandreev added need:specs Call for participation: specs are requested to fix this issue fix:bug Something isn't working labels Sep 6, 2024
@nortonandreev nortonandreev changed the title web-wallet: Define the usage of icons and colors in Card components and fix regressions web-wallet: Define and Implement Consistent Card Component Guidelines Sep 6, 2024
@laremas
Copy link
Member

laremas commented Sep 6, 2024

Mainly:

  • Icons on the left appears only when a warning action is happening in the card. (mainly related with the seedphrase). all the other icons are placed at the right

  • an icon generally is used to emphasise the card title and what is related about it, not all card title needs an icon (like in the wallet creation (verification, store the seed, etc)

  • colors, use dark grey as default one. (for icons) keep blue for hovering interaction when present.

  • Switch is placed before the icon when present. (check img below)

Screenshot 2024-09-06 at 10 40 31

Figma updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix:bug Something isn't working module:web-wallet Issues related to web-wallet module need:specs Call for participation: specs are requested to fix this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants