From 20b36f9483cef4b1f55152096da6320244df8ab7 Mon Sep 17 00:00:00 2001 From: Gerrit User 1188132 <1188132@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Date: Thu, 16 Mar 2017 21:33:53 +0000 Subject: [PATCH] Update patch set 4 Patch Set 4: > Patch Set 4: > > Sorry, but this is not the way to do that. Registry key approach was discussed downstream in nodejs, Heath Stewart who is responsible for the VS installer said explicitly that the registry entry is not supported (https://github.com/nodejs/node-gyp/pull/1103#issuecomment-280146014) > > In node-gyp we used Rafael's powershell script that can query VS COM server (https://github.com/nodejs/node-gyp/pull/1130). We used that to find VS and set environment variables. IMHO we should do the same thing here. Obviously, but I like this solution for this project, it's good enough... ... ... ... ... ... ... You know what, I'll make another PR with the full script Patch-set: 4 Reviewer: Gerrit User 1188132 <1188132@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>