Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade prettier to v3 #307

Merged
merged 1 commit into from
Mar 18, 2024
Merged

chore: upgrade prettier to v3 #307

merged 1 commit into from
Mar 18, 2024

Conversation

mcmxcdev
Copy link
Member

@mcmxcdev mcmxcdev commented Mar 17, 2024 •
edited
Loading

Changes

  • upgrade prettier from 2.4.1 to 3.2.5
  • add format npm script to package.json
  • run yarn format over full codebase

@vercel Vercel
Copy link

vercel bot commented Mar 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evm-codes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 3:32pm

@mcmxcdev Graphite App
Copy link
Member Author

mcmxcdev commented Mar 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mcmxcdev and the rest of your teammates on Graphite Graphite

@mcmxcdev mcmxcdev mentioned this pull request Mar 17, 2024
Merged
@mcmxcdev mcmxcdev mentioned this pull request Mar 17, 2024
Merged
@mcmxcdev mcmxcdev marked this pull request as ready for review March 18, 2024 14:02
@mcmxcdev mcmxcdev requested review from 2xic and charisra March 18, 2024 14:02
charisra
charisra previously approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@charisra charisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know we're using any yarn command in this codebase...

@mcmxcdev
Copy link
Member Author

Didn't know we're using any yarn command in this codebase...

evm.codes is still using yarn v1 (which is deprecated since 2020), I might switch it over to pnpm once the contract viewer PR gets merged.

Base automatically changed from chore/upgrade-all-non-major-dependencies to main March 18, 2024 15:29
@mcmxcdev mcmxcdev dismissed charisra’s stale review March 18, 2024 15:29

The base branch was changed.

@mcmxcdev
chore: upgrade prettier to v3
6b5341d 
- upgrade prettier from 2.4.1 to 3.2.5
- add format npm script to package.json
- run pnpm format over full codebase
@mcmxcdev mcmxcdev force-pushed the chore/upgrade-prettier-to-v3 branch from 56fa7b2 to 6b5341d Compare March 18, 2024 15:29
@mcmxcdev Graphite App
Copy link
Member Author

mcmxcdev commented Mar 18, 2024 •
edited
Loading

Merge activity

  • Mar 18, 11:30 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Mar 18, 11:35 AM EDT: @mcmxcdev merged this pull request with Graphite.

@mcmxcdev mcmxcdev merged commit d21b28b into main Mar 18, 2024
2 checks passed
@mcmxcdev mcmxcdev deleted the chore/upgrade-prettier-to-v3 branch March 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisra charisra charisra approved these changes

@2xic 2xic Awaiting requested review from 2xic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcmxcdev @charisra