Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ethereumjs libraries #304

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Bump ethereumjs libraries #304

merged 1 commit into from
Mar 14, 2024

Conversation

2xic
Copy link
Collaborator

@2xic 2xic commented Mar 14, 2024

Short summary of the changes

  • Needed to add two webpack / babel loaders to be able to import rustbn used by Ethereumjs.
  • There was some minor changes to the types used by EthereumJS so updated to reflect the new types.
    • Mainly HardforkConfig -> HardforkTransitionConfig
    • Buffer -> Uint8Array
    • getActiveOpcodes isn't exposed on vm anymore, just reconstructing the input to EVM was easiest.

Test plan

  1. Make sure the fork selector correctly reflect the active opcodes (i.e PUSH0 should not be shown in Paris hardfork) ✅
Screenshot 2024-03-14 at 14 43 32
  1. Playground should have it's storage and stack be correctly updated when running through a contract that interacts with storage ✅
Screenshot 2024-03-14 at 14 46 33
  1. Check that dynamic gas cost is correctly reflected based on version (i.e check that the dynamic cost of CREATE is correctly shown in Shanghai and is different from the Paris version) ✅

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evm-codes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 1:39pm

@2xic
Copy link
Collaborator Author

2xic commented Mar 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @2xic and the rest of your teammates on Graphite Graphite

@2xic 2xic force-pushed the feature/update-ethereumjs-libs branch from 61448b0 to f3baa0e Compare March 14, 2024 13:37
@2xic 2xic requested review from peroket and thevaizman March 14, 2024 13:59
@2xic 2xic marked this pull request as ready for review March 14, 2024 13:59
@2xic 2xic merged commit 04ca661 into main Mar 14, 2024
2 checks passed
@2xic 2xic deleted the feature/update-ethereumjs-libs branch March 14, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants