Replace difficulty with prevrandao #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ethereumjs version of all packages (contains breaking changes) Refactor areas of the code that broke due to changes in ethereumjs Added "merge" HF to the HF selection menu Added workaround logic to change "difficulty" opcode to "prevrandao" if "merge" is the chosen HF (still WIP - will probably change this in a future commit before merging)
Replaced the unsustainable method overriding in _setupStateManager() to a much more robust Proxy API implementation. We now create a proxified EVMEEI object that allows us to intercept putContractStorage and clearContractStorage without ever overriding them. This guarantees us to be compliant with future changes in @ethereumjs/evm and still be able to capture storage clear/put operations. Also, unrelated, this commit contains a fix to getTargetEvmVersion() in order to correctly get the target evmVersion for compilation. Lastly, this commit contains a lint fix in DocRow.tsx
Added a very hacky `prebuild.sh` script to allow build to successfully finish when using the latest ethereumjs version. The script basically uses `sed` in order to replace 2 faulty lines that won't compile for us because we use ESM and ethereumjs migrated to CommonJS. Please refer to this issue for mor details: ethereumjs/ethereumjs-monorepo#2295
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
peroket
reviewed
Oct 12, 2022
darkdarkdragon
suggested changes
Oct 14, 2022
Co-authored-by: Ivan Tivonenko <[email protected]>
Co-authored-by: Ivan Tivonenko <[email protected]>
Co-authored-by: Ivan Tivonenko <[email protected]>
Co-authored-by: Ivan Tivonenko <[email protected]>
Co-authored-by: Ivan Tivonenko <[email protected]>
Co-authored-by: Ivan Tivonenko <[email protected]>
Co-authored-by: Ivan Tivonenko <[email protected]>
Co-authored-by: Ivan Tivonenko <[email protected]>
Co-authored-by: Ivan Tivonenko <[email protected]>
ethosdev
reviewed
Oct 16, 2022
darkdarkdragon
previously approved these changes
Oct 17, 2022
assimovt
previously requested changes
Oct 17, 2022
There was a problem hiding this comment.
hey @thevaizman thx for the PR and for going down the rabbit hole with the ethereumjs/TS issues. I left a few comments, mainly on the code styling, but otherwise LGTM. If there is an existing branch for properly fixing the issue, so that we can get rid of the build script, we could already create another issue in this repo to track it and update to the latest. Cheers ✌🏽
dorlevi
approved these changes
Oct 21, 2022
dorlevi
approved these changes
Oct 21, 2022
dorlevi
approved these changes
Oct 21, 2022
dorlevi
dismissed
assimovt’s stale review
addressed, and want to merge without blocking on tair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains quite a lot of code that had to be refactored in order to use the latest
ethereumjslibrary (which supports the merge).In addition a hacky prebuild script was added to the build process. Details for why we did that are here.
Please review this thoroughly :)