From 8917abe847b759fd2532500c7bd8db0b03e36d25 Mon Sep 17 00:00:00 2001 From: Tomas Strba Date: Wed, 27 Jul 2022 14:35:54 +0200 Subject: [PATCH 1/5] file_length and type_body_length adjusted --- .swiftlint.yml | 5 ++++- DuckDuckGo/Bookmarks/Services/BookmarkStore.swift | 2 -- DuckDuckGo/Browser Tab/Model/Tab.swift | 1 - DuckDuckGo/Browser Tab/View/BrowserTabViewController.swift | 4 ---- .../Logins/Firefox/FirefoxEncryptionKeyReader.swift | 1 - DuckDuckGo/Data Import/View/DataImportViewController.swift | 2 -- .../View/FeedbackViewController.swift | 2 -- DuckDuckGo/Main/View/MainViewController.swift | 1 - DuckDuckGo/Menus/MainMenuActions.swift | 2 -- .../View/AddressBarButtonsViewController.swift | 7 +------ DuckDuckGo/Navigation Bar/View/AddressBarTextField.swift | 6 ------ .../Navigation Bar/View/AddressBarViewController.swift | 2 -- .../Navigation Bar/View/NavigationBarViewController.swift | 2 -- DuckDuckGo/Permissions/Model/PermissionModel.swift | 1 - .../View/PasswordManagementViewController.swift | 6 +----- DuckDuckGo/Tab Bar/View/TabBarViewController.swift | 3 --- DuckDuckGo/Tab Bar/ViewModel/TabCollectionViewModel.swift | 2 -- .../File Download/DownloadListCoordinatorTests.swift | 2 -- Unit Tests/Geolocation/GeolocationProviderTests.swift | 5 ----- Unit Tests/Permissions/PermissionModelTests.swift | 6 +----- .../Tab Bar/ViewModel/TabCollectionViewModelTests.swift | 1 - 21 files changed, 7 insertions(+), 56 deletions(-) diff --git a/.swiftlint.yml b/.swiftlint.yml index d3c0b38a5d..ed8a83841d 100644 --- a/.swiftlint.yml +++ b/.swiftlint.yml @@ -37,8 +37,11 @@ type_name: warning: 80 error: 100 file_length: - warning: 700 + warning: 1200 error: 1200 +type_body_length: + warning: 500 + error: 500 nesting: type_level: 2 file_header: diff --git a/DuckDuckGo/Bookmarks/Services/BookmarkStore.swift b/DuckDuckGo/Bookmarks/Services/BookmarkStore.swift index d778619138..710696781c 100644 --- a/DuckDuckGo/Bookmarks/Services/BookmarkStore.swift +++ b/DuckDuckGo/Bookmarks/Services/BookmarkStore.swift @@ -52,7 +52,6 @@ protocol BookmarkStore { } -// swiftlint:disable type_body_length final class LocalBookmarkStore: BookmarkStore { init() {} @@ -582,4 +581,3 @@ fileprivate extension BookmarkManagedObject { } } -// swiftlint:enable type_body_length diff --git a/DuckDuckGo/Browser Tab/Model/Tab.swift b/DuckDuckGo/Browser Tab/Model/Tab.swift index aaaaadec08..11c57288e4 100644 --- a/DuckDuckGo/Browser Tab/Model/Tab.swift +++ b/DuckDuckGo/Browser Tab/Model/Tab.swift @@ -40,7 +40,6 @@ protocol TabDelegate: FileDownloadManagerDelegate, ContentOverlayUserScriptDeleg func closeTab(_ tab: Tab) } -// swiftlint:disable type_body_length // swiftlint:disable file_length final class Tab: NSObject, Identifiable, ObservableObject { diff --git a/DuckDuckGo/Browser Tab/View/BrowserTabViewController.swift b/DuckDuckGo/Browser Tab/View/BrowserTabViewController.swift index ee60a2e472..139f7014ab 100644 --- a/DuckDuckGo/Browser Tab/View/BrowserTabViewController.swift +++ b/DuckDuckGo/Browser Tab/View/BrowserTabViewController.swift @@ -27,8 +27,6 @@ protocol BrowserTabViewControllerClickDelegate: AnyObject { func browserTabViewController(_ browserTabViewController: BrowserTabViewController, didClickAtPoint: CGPoint) } -// swiftlint:disable file_length -// swiftlint:disable:next type_body_length final class BrowserTabViewController: NSViewController { @IBOutlet weak var errorView: NSView! @@ -1162,5 +1160,3 @@ extension BrowserTabViewController { } } } - -// swiftlint:enable file_length diff --git a/DuckDuckGo/Data Import/Logins/Firefox/FirefoxEncryptionKeyReader.swift b/DuckDuckGo/Data Import/Logins/Firefox/FirefoxEncryptionKeyReader.swift index ec36e7fe3f..c8429ca6ef 100644 --- a/DuckDuckGo/Data Import/Logins/Firefox/FirefoxEncryptionKeyReader.swift +++ b/DuckDuckGo/Data Import/Logins/Firefox/FirefoxEncryptionKeyReader.swift @@ -28,7 +28,6 @@ protocol FirefoxEncryptionKeyReading { } -// swiftlint:disable:next type_body_length final class FirefoxEncryptionKeyReader: FirefoxEncryptionKeyReading { func getEncryptionKey(key3DatabaseURL: URL, primaryPassword: String) -> Result { diff --git a/DuckDuckGo/Data Import/View/DataImportViewController.swift b/DuckDuckGo/Data Import/View/DataImportViewController.swift index 88f1484f46..a920795398 100644 --- a/DuckDuckGo/Data Import/View/DataImportViewController.swift +++ b/DuckDuckGo/Data Import/View/DataImportViewController.swift @@ -21,7 +21,6 @@ import BrowserServicesKit import Combine import os.log -// swiftlint:disable type_body_length final class DataImportViewController: NSViewController { enum Constants { @@ -453,7 +452,6 @@ final class DataImportViewController: NSViewController { } } -// swiftlint:enable type_body_length extension DataImportViewController: FileImportViewControllerDelegate { diff --git a/DuckDuckGo/Feedback and Breakage/View/FeedbackViewController.swift b/DuckDuckGo/Feedback and Breakage/View/FeedbackViewController.swift index ee2d25dc7f..92b140e11d 100644 --- a/DuckDuckGo/Feedback and Breakage/View/FeedbackViewController.swift +++ b/DuckDuckGo/Feedback and Breakage/View/FeedbackViewController.swift @@ -19,7 +19,6 @@ import Cocoa import Combine -// swiftlint:disable type_body_length final class FeedbackViewController: NSViewController { enum Constants { @@ -325,7 +324,6 @@ final class FeedbackViewController: NSViewController { thankYouView.isHidden = false } } -// swiftlint:enable type_body_length fileprivate extension WebsiteBreakage.Category { diff --git a/DuckDuckGo/Main/View/MainViewController.swift b/DuckDuckGo/Main/View/MainViewController.swift index 58d5fcd74a..b767625dbf 100644 --- a/DuckDuckGo/Main/View/MainViewController.swift +++ b/DuckDuckGo/Main/View/MainViewController.swift @@ -21,7 +21,6 @@ import Carbon.HIToolbox import Combine import os.log -// swiftlint:disable type_body_length final class MainViewController: NSViewController { @IBOutlet weak var tabBarContainerView: NSView! diff --git a/DuckDuckGo/Menus/MainMenuActions.swift b/DuckDuckGo/Menus/MainMenuActions.swift index 648b156db2..ba7fc1a795 100644 --- a/DuckDuckGo/Menus/MainMenuActions.swift +++ b/DuckDuckGo/Menus/MainMenuActions.swift @@ -16,8 +16,6 @@ // limitations under the License. // -// swiftlint:disable file_length - import Cocoa import os.log import BrowserServicesKit diff --git a/DuckDuckGo/Navigation Bar/View/AddressBarButtonsViewController.swift b/DuckDuckGo/Navigation Bar/View/AddressBarButtonsViewController.swift index 9cde1b6338..b612b55bdc 100644 --- a/DuckDuckGo/Navigation Bar/View/AddressBarButtonsViewController.swift +++ b/DuckDuckGo/Navigation Bar/View/AddressBarButtonsViewController.swift @@ -27,8 +27,7 @@ protocol AddressBarButtonsViewControllerDelegate: AnyObject { } -// swiftlint:disable type_body_length -// swiftlint:disable file_length +// swiftlint:disable:next type_body_length final class AddressBarButtonsViewController: NSViewController { static let homeFaviconImage = NSImage(named: "Search") @@ -867,7 +866,6 @@ final class AddressBarButtonsViewController: NSViewController { } } -// swiftlint:enable type_body_length extension AddressBarButtonsViewController: PermissionContextMenuDelegate { @@ -928,6 +926,3 @@ final class TrackerAnimationImageProvider: AnimationImageProvider { } } - -// swiftlint:enable type_body_length -// swiftlint:enable file_length diff --git a/DuckDuckGo/Navigation Bar/View/AddressBarTextField.swift b/DuckDuckGo/Navigation Bar/View/AddressBarTextField.swift index 5e2ca3395e..c1d99f79f2 100644 --- a/DuckDuckGo/Navigation Bar/View/AddressBarTextField.swift +++ b/DuckDuckGo/Navigation Bar/View/AddressBarTextField.swift @@ -21,9 +21,6 @@ import Combine import os.log import BrowserServicesKit -// swiftlint:disable file_length -// swiftlint:disable type_body_length - protocol AddressBarTextFieldDelegate: AnyObject { func adressBarTextField(_ addressBarTextField: AddressBarTextField, didChangeValue value: AddressBarTextField.Value) @@ -1079,6 +1076,3 @@ final class AddressBarTextFieldCell: NSTextFieldCell { fileprivate extension NSStoryboard { static let suggestion = NSStoryboard(name: "Suggestion", bundle: .main) } - -// swiftlint:enable type_body_length -// swiftlint:enable file_length diff --git a/DuckDuckGo/Navigation Bar/View/AddressBarViewController.swift b/DuckDuckGo/Navigation Bar/View/AddressBarViewController.swift index fbb88e036a..ac24ef1c6c 100644 --- a/DuckDuckGo/Navigation Bar/View/AddressBarViewController.swift +++ b/DuckDuckGo/Navigation Bar/View/AddressBarViewController.swift @@ -21,7 +21,6 @@ import os.log import Combine import Lottie -// swiftlint:disable type_body_length final class AddressBarViewController: NSViewController { @IBOutlet weak var addressBarTextField: AddressBarTextField! @@ -354,7 +353,6 @@ final class AddressBarViewController: NSViewController { } } -// swiftlint:enable type_body_length extension AddressBarViewController { diff --git a/DuckDuckGo/Navigation Bar/View/NavigationBarViewController.swift b/DuckDuckGo/Navigation Bar/View/NavigationBarViewController.swift index 17abca71b5..ed0c13d033 100644 --- a/DuckDuckGo/Navigation Bar/View/NavigationBarViewController.swift +++ b/DuckDuckGo/Navigation Bar/View/NavigationBarViewController.swift @@ -21,7 +21,6 @@ import Combine import os.log import BrowserServicesKit -// swiftlint:disable type_body_length file_length final class NavigationBarViewController: NSViewController { enum Constants { @@ -628,7 +627,6 @@ final class NavigationBarViewController: NSViewController { } } -// swiftlint:enable type_body_length extension NavigationBarViewController: OptionsButtonMenuDelegate { diff --git a/DuckDuckGo/Permissions/Model/PermissionModel.swift b/DuckDuckGo/Permissions/Model/PermissionModel.swift index 511558e4d7..358bea7e6f 100644 --- a/DuckDuckGo/Permissions/Model/PermissionModel.swift +++ b/DuckDuckGo/Permissions/Model/PermissionModel.swift @@ -22,7 +22,6 @@ import WebKit import AVFoundation import CoreLocation -// swiftlint:disable:next type_body_length final class PermissionModel { @PublishedAfter var permissions = Permissions() diff --git a/DuckDuckGo/Secure Vault/View/PasswordManagementViewController.swift b/DuckDuckGo/Secure Vault/View/PasswordManagementViewController.swift index abb295190d..726b8cffb0 100644 --- a/DuckDuckGo/Secure Vault/View/PasswordManagementViewController.swift +++ b/DuckDuckGo/Secure Vault/View/PasswordManagementViewController.swift @@ -21,8 +21,6 @@ import Combine import SwiftUI import BrowserServicesKit -// swiftlint:disable file_length - protocol PasswordManagementDelegate: AnyObject { /// May not be called on main thread. @@ -30,7 +28,7 @@ protocol PasswordManagementDelegate: AnyObject { } -// swiftlint:disable type_body_length +// swiftlint:disable:next type_body_length final class PasswordManagementViewController: NSViewController { static func create() -> Self { @@ -926,5 +924,3 @@ extension PasswordManagementViewController: NSTextViewDelegate { } } - -// swiftlint:enable file_length diff --git a/DuckDuckGo/Tab Bar/View/TabBarViewController.swift b/DuckDuckGo/Tab Bar/View/TabBarViewController.swift index 73e334429f..4792da158c 100644 --- a/DuckDuckGo/Tab Bar/View/TabBarViewController.swift +++ b/DuckDuckGo/Tab Bar/View/TabBarViewController.swift @@ -22,9 +22,6 @@ import Combine import Lottie import SwiftUI -// swiftlint:disable file_length -// swiftlint:disable type_body_length - final class TabBarViewController: NSViewController { enum HorizontalSpace: CGFloat { diff --git a/DuckDuckGo/Tab Bar/ViewModel/TabCollectionViewModel.swift b/DuckDuckGo/Tab Bar/ViewModel/TabCollectionViewModel.swift index d953e52d71..65ec5e26ad 100644 --- a/DuckDuckGo/Tab Bar/ViewModel/TabCollectionViewModel.swift +++ b/DuckDuckGo/Tab Bar/ViewModel/TabCollectionViewModel.swift @@ -36,7 +36,6 @@ protocol TabCollectionViewModelDelegate: AnyObject { } -// swiftlint:disable type_body_length final class TabCollectionViewModel: NSObject { weak var delegate: TabCollectionViewModelDelegate? @@ -634,4 +633,3 @@ extension TabCollectionViewModel { } } -// swiftlint:enable type_body_length diff --git a/Unit Tests/File Download/DownloadListCoordinatorTests.swift b/Unit Tests/File Download/DownloadListCoordinatorTests.swift index 01070bd540..ad2e6d5427 100644 --- a/Unit Tests/File Download/DownloadListCoordinatorTests.swift +++ b/Unit Tests/File Download/DownloadListCoordinatorTests.swift @@ -20,7 +20,6 @@ import Foundation import XCTest @testable import DuckDuckGo_Privacy_Browser -// swiftlint:disable type_body_length @available(macOS 11.3, *) final class DownloadListCoordinatorTests: XCTestCase { let store = DownloadListStoreMock() @@ -437,7 +436,6 @@ final class DownloadListCoordinatorTests: XCTestCase { } } -// swiftlint:enable type_body_length private struct TestError: Error, Equatable {} private extension Data { diff --git a/Unit Tests/Geolocation/GeolocationProviderTests.swift b/Unit Tests/Geolocation/GeolocationProviderTests.swift index 278c3d22f5..6e49a6384c 100644 --- a/Unit Tests/Geolocation/GeolocationProviderTests.swift +++ b/Unit Tests/Geolocation/GeolocationProviderTests.swift @@ -23,8 +23,6 @@ import CoreLocation import WebKit @testable import DuckDuckGo_Privacy_Browser -// swiftlint:disable file_length -// swiftlint:disable type_body_length // swiftlint:disable function_body_length final class GeolocationProviderTests: XCTestCase { @@ -659,7 +657,6 @@ final class GeolocationProviderTests: XCTestCase { } } -// swiftlint:enable type_body_length // swiftlint:enable function_body_length extension GeolocationProviderTests: WKUIDelegate { @@ -769,5 +766,3 @@ extension CLLocation { } } } - -// swiftlint:enable file_length diff --git a/Unit Tests/Permissions/PermissionModelTests.swift b/Unit Tests/Permissions/PermissionModelTests.swift index 855e846944..cda3fa6ece 100644 --- a/Unit Tests/Permissions/PermissionModelTests.swift +++ b/Unit Tests/Permissions/PermissionModelTests.swift @@ -23,8 +23,7 @@ import Combine import AVFoundation @testable import DuckDuckGo_Privacy_Browser -// swiftlint:disable file_length -// swiftlint:disable type_body_length +// swiftlint:disable:next type_body_length final class PermissionModelTests: XCTestCase { let permissionManagerMock = PermissionManagerMock() @@ -1151,6 +1150,3 @@ extension PermissionModelTests: WebViewPermissionsDelegate { } } - -// swiftlint:enable type_body_length -// swiftlint:enable file_length diff --git a/Unit Tests/Tab Bar/ViewModel/TabCollectionViewModelTests.swift b/Unit Tests/Tab Bar/ViewModel/TabCollectionViewModelTests.swift index 2b2c72e3ea..b02f7a26ab 100644 --- a/Unit Tests/Tab Bar/ViewModel/TabCollectionViewModelTests.swift +++ b/Unit Tests/Tab Bar/ViewModel/TabCollectionViewModelTests.swift @@ -19,7 +19,6 @@ import XCTest @testable import DuckDuckGo_Privacy_Browser -// swiftlint:disable:next type_body_length final class TabCollectionViewModelTests: XCTestCase { // MARK: - TabViewModel From e6b8b0a06fa362b04b557ecf36bf03636b60d651 Mon Sep 17 00:00:00 2001 From: Tomas Strba Date: Wed, 3 Aug 2022 12:29:15 +0200 Subject: [PATCH 2/5] line_length disabled globally --- .swiftlint.yml | 1 + .../Secure Vault/Extensions/UserText+PasswordManager.swift | 1 - Unit Tests/AutoconsentMessageProtocolTests.swift | 2 -- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.swiftlint.yml b/.swiftlint.yml index ed8a83841d..8470e8eff1 100644 --- a/.swiftlint.yml +++ b/.swiftlint.yml @@ -6,6 +6,7 @@ disabled_rules: - block_based_kvo - compiler_protocol_init - unused_setter_value + - line_length opt_in_rules: - file_header diff --git a/DuckDuckGo/Secure Vault/Extensions/UserText+PasswordManager.swift b/DuckDuckGo/Secure Vault/Extensions/UserText+PasswordManager.swift index e293e0760f..77a1bad948 100644 --- a/DuckDuckGo/Secure Vault/Extensions/UserText+PasswordManager.swift +++ b/DuckDuckGo/Secure Vault/Extensions/UserText+PasswordManager.swift @@ -18,7 +18,6 @@ import Foundation -// swiftlint:disable line_length extension UserText { static let pmSaveCredentialsEditableTitle = NSLocalizedString("pm.save-credentials.editable.title", value: "Save Login?", comment: "Title for the editable Save Credentials popover") diff --git a/Unit Tests/AutoconsentMessageProtocolTests.swift b/Unit Tests/AutoconsentMessageProtocolTests.swift index 39e72c5ba1..c84f4f3818 100644 --- a/Unit Tests/AutoconsentMessageProtocolTests.swift +++ b/Unit Tests/AutoconsentMessageProtocolTests.swift @@ -65,11 +65,9 @@ class AutoconsentMessageProtocolTests: XCTestCase { userScript.handleMessage( replyHandler: {(msg: Any?, _: String?) in expect.fulfill() - // swiftlint:disable line_length XCTAssertEqual(self.replyToJson(msg: msg!), """ {"config":{"autoAction":"optOut","detectRetries":20,"disabledCmps":[],"enabled":true,"enablePrehide":true},"rules":null,"type":"initResp"} """) - // swiftlint:enable line_length }, message: message ) From 8b4ee407d848078b17c4d61d1b3d626522870f68 Mon Sep 17 00:00:00 2001 From: Dominik Kapusta Date: Fri, 5 Aug 2022 15:09:56 +0200 Subject: [PATCH 3/5] Remove outstanding type_body_length and line_length rule exceptions Also remove line_length configuration from .swiftlint.yml since it has been disabled, and as such it produces a compile warning. --- .swiftlint.yml | 3 --- DuckDuckGo/Fire/Model/Fire.swift | 1 - DuckDuckGo/History/Model/HistoryCoordinator.swift | 1 - DuckDuckGo/Menus/MainMenuActions.swift | 2 -- 4 files changed, 7 deletions(-) diff --git a/.swiftlint.yml b/.swiftlint.yml index 8470e8eff1..51bf3d5e95 100644 --- a/.swiftlint.yml +++ b/.swiftlint.yml @@ -24,9 +24,6 @@ custom_rules: severity: error # Rule Config -line_length: - warning: 150 - ignores_comments: true identifier_name: min_length: 1 max_length: diff --git a/DuckDuckGo/Fire/Model/Fire.swift b/DuckDuckGo/Fire/Model/Fire.swift index f65d12d2c4..fd40251dce 100644 --- a/DuckDuckGo/Fire/Model/Fire.swift +++ b/DuckDuckGo/Fire/Model/Fire.swift @@ -74,7 +74,6 @@ final class TabDataCleaner: NSObject, WKNavigationDelegate { } } -// swiftlint:disable type_body_length final class Fire { // Drop www prefixes to produce list of burning domains diff --git a/DuckDuckGo/History/Model/HistoryCoordinator.swift b/DuckDuckGo/History/Model/HistoryCoordinator.swift index 5db33eb38f..a781a42dba 100644 --- a/DuckDuckGo/History/Model/HistoryCoordinator.swift +++ b/DuckDuckGo/History/Model/HistoryCoordinator.swift @@ -40,7 +40,6 @@ protocol HistoryCoordinating: AnyObject { } -// swiftlint:disable type_body_length /// Coordinates access to History. Uses its own queue with high qos for all operations. final class HistoryCoordinator: HistoryCoordinating { diff --git a/DuckDuckGo/Menus/MainMenuActions.swift b/DuckDuckGo/Menus/MainMenuActions.swift index 360f1a578a..4b732ac82b 100644 --- a/DuckDuckGo/Menus/MainMenuActions.swift +++ b/DuckDuckGo/Menus/MainMenuActions.swift @@ -20,8 +20,6 @@ import Cocoa import os.log import BrowserServicesKit -// swiftlint:disable file_length - // Actions are sent to objects of responder chain // MARK: - Main Menu Actions From 09a34532f8ec0282ef7d83685eda9d9467a5b1f5 Mon Sep 17 00:00:00 2001 From: Tomas Strba Date: Sat, 6 Aug 2022 15:27:02 +0200 Subject: [PATCH 4/5] Xcode warnings resolved --- DuckDuckGo.xcodeproj/project.pbxproj | 2 +- .../xcshareddata/xcschemes/DuckDuckGo Privacy Browser.xcscheme | 2 +- .../xcshareddata/xcschemes/Integration Tests.xcscheme | 2 +- .../xcshareddata/xcschemes/Product Review Release.xcscheme | 2 +- .../xcschemes/Pull Request Testing with TSan.xcscheme | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/DuckDuckGo.xcodeproj/project.pbxproj b/DuckDuckGo.xcodeproj/project.pbxproj index 0a14bc0215..9d4ecbb382 100644 --- a/DuckDuckGo.xcodeproj/project.pbxproj +++ b/DuckDuckGo.xcodeproj/project.pbxproj @@ -4212,7 +4212,7 @@ isa = PBXProject; attributes = { LastSwiftUpdateCheck = 1250; - LastUpgradeCheck = 1320; + LastUpgradeCheck = 1340; ORGANIZATIONNAME = DuckDuckGo; TargetAttributes = { 4B1AD89C25FC27E200261379 = { diff --git a/DuckDuckGo.xcodeproj/xcshareddata/xcschemes/DuckDuckGo Privacy Browser.xcscheme b/DuckDuckGo.xcodeproj/xcshareddata/xcschemes/DuckDuckGo Privacy Browser.xcscheme index 399d786f32..4bb3d8bb5c 100644 --- a/DuckDuckGo.xcodeproj/xcshareddata/xcschemes/DuckDuckGo Privacy Browser.xcscheme +++ b/DuckDuckGo.xcodeproj/xcshareddata/xcschemes/DuckDuckGo Privacy Browser.xcscheme @@ -1,6 +1,6 @@ Date: Sat, 6 Aug 2022 15:33:05 +0200 Subject: [PATCH 5/5] SwiftLint warning after merge resolved --- Unit Tests/Bookmarks/Services/LocalBookmarkStoreTests.swift | 1 - 1 file changed, 1 deletion(-) diff --git a/Unit Tests/Bookmarks/Services/LocalBookmarkStoreTests.swift b/Unit Tests/Bookmarks/Services/LocalBookmarkStoreTests.swift index 867535531c..b5a06d9194 100644 --- a/Unit Tests/Bookmarks/Services/LocalBookmarkStoreTests.swift +++ b/Unit Tests/Bookmarks/Services/LocalBookmarkStoreTests.swift @@ -21,7 +21,6 @@ import Foundation import XCTest @testable import DuckDuckGo_Privacy_Browser -// swiftlint:disable:next type_body_length final class LocalBookmarkStoreTests: XCTestCase { func testWhenBookmarkIsSaved_ThenItMustBeLoadedFromStore() {