Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin config #115

Merged
merged 4 commits into from
Feb 8, 2021
Merged

Admin config #115

merged 4 commits into from
Feb 8, 2021

Conversation

ztelur
Copy link
Contributor

@ztelur ztelur commented Feb 8, 2021 •
edited
Loading

What this PR does:

fix bug

Which issue(s) this PR fixes:

Fixes #

  • plugin reload when remote api config change

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-io
Copy link

Codecov Report

Merging #115 (cdb8151) into 0.2.0 (cc456d6) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            0.2.0     #115      +/-   ##
==========================================
- Coverage   40.65%   40.60%   -0.05%     
==========================================
  Files          35       35              
  Lines        1690     1692       +2     
==========================================
  Hits          687      687              
- Misses        901      903       +2     
  Partials      102      102
Impacted Files Coverage Δ
pkg/service/api/discovery_service.go 65.00% <0.00%> (-2.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc456d6...cdb8151. Read the comment docs.

@xiaoliu10 xiaoliu10 added this to the v0.2.0 milestone Feb 8, 2021
@xiaoliu10 xiaoliu10 merged commit 008bffe into apache:0.2.0 Feb 8, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
@xiaoliu10
Merge pull request #115 from ztelur/admin_config
ffb8c6b 
Admin config

Former-commit-id: 9441cbe [formerly 008bffe]
Former-commit-id: 9441cbe
Former-commit-id: f68b812
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
@xiaoliu10
Merge pull request apache#115 from ztelur/admin_config
69dc1d2 
Admin config

Former-commit-id: 7775987 [formerly 9441cbe [formerly 008bffe]]
Former-commit-id: 9d4b0b9 [formerly 9441cbe]
Former-commit-id: ffb8c6b [formerly f68b812]
Former-commit-id: 30950d1
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
@xiaoliu10
Merge pull request apache#115 from ztelur/admin_config
3527897 
Admin config

Former-commit-id: 008bffe
Former-commit-id: 9441cbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cityiron cityiron cityiron approved these changes

@mark4z mark4z mark4z approved these changes

@xiaoliu10 xiaoliu10 xiaoliu10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ztelur @codecov-io @xiaoliu10 @mark4z @cityiron