Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace filter interface #109

Closed
wants to merge 12 commits into from
Closed

Replace filter interface #109

wants to merge 12 commits into from

Conversation

mark4z
Copy link
Member

@mark4z mark4z commented Jan 16, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #108

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


pkg/model/base.go Show resolved Hide resolved
pkg/model/base.go Show resolved Hide resolved
pkg/model/base.go Show resolved Hide resolved
pkg/model/base.go Show resolved Hide resolved
pkg/model/base.go Show resolved Hide resolved
pkg/model/base.go Show resolved Hide resolved
pkg/model/base.go Show resolved Hide resolved
pkg/model/base.go Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #109 (b434c39) into develop (a654db8) will decrease coverage by 0.47%.
The diff coverage is 68.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #109      +/-   ##
===========================================
- Coverage    41.84%   41.36%   -0.48%     
===========================================
  Files           33       33              
  Lines         1410     1378      -32     
===========================================
- Hits           590      570      -20     
+ Misses         736      730       -6     
+ Partials        84       78       -6     
Impacted Files Coverage Δ
pkg/client/dubbo/dubbo.go 22.01% <ø> (ø)
pkg/client/mapper.go 78.94% <ø> (ø)
pkg/client/request.go 0.00% <ø> (ø)
pkg/filter/accesslog/access_log.go 4.08% <ø> (ø)
pkg/filter/recovery/recovery.go 77.77% <ø> (ø)
pkg/filter/replacepath/replace_path.go 61.11% <ø> (ø)
pkg/filter/response/response.go 5.38% <0.00%> (ø)
pkg/registry/util.go 0.00% <ø> (ø)
pkg/router/api.go 100.00% <ø> (ø)
pkg/client/http/http.go 60.31% <33.33%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a654db8...b434c39. Read the comment docs.

@xiaoliu10 xiaoliu10 added this to the v0.2.0 milestone Jan 18, 2021
@mark4z mark4z closed this Jan 19, 2021
@mark4z mark4z reopened this Jan 19, 2021
@mark4z mark4z closed this Jan 20, 2021
@mark4z mark4z deleted the plugin branch March 18, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra filter interface for plugin
3 participants