Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pending tests #98

Open
4 of 7 tasks
duaraghav8 opened this issue Aug 11, 2017 · 4 comments
Open
4 of 7 tasks

pending tests #98

duaraghav8 opened this issue Aug 11, 2017 · 4 comments

Comments

@duaraghav8
Copy link
Owner

duaraghav8 commented Aug 11, 2017

Need to write tests for:

  • function-order rule's ignore options
  • Indentation rule(s) - 00bc6d2
  • Autofix API & mechanism
  • everything in v1 #97
  • Messages supplied by exceptions
  • Tests for rules of the security plugin https://github.com/duaraghav8/solium-plugin-security
  • Test for all rules that work with line breaks (blank-lines, indentation, whitespace, etc) - need to test that they work as expected on linux, mac & windows (different platforms have different newline encoding)
@fvictorio
Copy link
Contributor

Hi, I'd like to help with the tests for the indentation rules, if no one is already working on that. I'm just getting familiar with the codebase, but this seems approachable to me.

Do you manage issues assignments in some way to avoid work duplication? Or is this comment enough to let others know?

@duaraghav8
Copy link
Owner Author

@fvictorio nobody is currently working on it and you're free to take this up. If you do, just let me know and I'll add the In Progress tag to this issue.
Thanks for your contributions! You can always DM me on our Gitter Channel or email me in case you have any doubts or suggestions.

@fvictorio
Copy link
Contributor

Cool! Mark it as In Progress if you want, I'll start working on it.

@duaraghav8
Copy link
Owner Author

Indentation: add test for #268 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants