Skip to content
This repository has been archived by the owner on Oct 6, 2024. It is now read-only.

Behavior changes unexpectedly in 0.1.17 #38

Closed
kulp opened this issue Jun 21, 2020 · 2 comments · Fixed by #39
Closed

Behavior changes unexpectedly in 0.1.17 #38

kulp opened this issue Jun 21, 2020 · 2 comments · Fixed by #39

Comments

@kulp
Copy link

kulp commented Jun 21, 2020

Is there a known change in behavior in 0.1.17 ?

I see that the changes 0.1.16...0.1.17 are significant in terms of implementation, but it is not obvious that there should be different behavior. However, I found in lightning-sys that the macro expansion was significantly different.

As of petelliott/lightning-sys@ba3bffb :

$ cargo update -p paste --precise 0.1.16
$ cargo expand --lib | sed -n '/^pub mod jitstate/,/^}/p' > with-0.1.16.txt
$ cargo update -p paste --precise 0.1.17
$ cargo expand --lib | sed -n '/^pub mod jitstate/,/^}/p' > with-0.1.17.txt
$ wc -l with-0.1.1*.txt
    4950 with-0.1.16.txt
    4229 with-0.1.17.txt

with-0.1.16.txt
with-0.1.17.txt

I have not boiled down a small test case.

@dtolnay
Copy link
Owner

dtolnay commented Jun 21, 2020

Sorry about the breakage, this is fixed in 0.1.18.

@kulp
Copy link
Author

kulp commented Jun 21, 2020

I confirm. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants