Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 253 readthedocs #269

Merged
merged 1 commit into from
Mar 10, 2021
Merged

feature 253 readthedocs #269

merged 1 commit into from
Mar 10, 2021

Conversation

jprestop
Copy link
Contributor

@jprestop jprestop commented Mar 9, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

    Set up ReadTheDocs for MET and verified everything looked good here:
    https://metviewer.readthedocs.io/en/feature_253_readthedocs/
    Note that "latest" will point to "develop" until the release since this is the first version of documentation we've had for METviewer

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review the "Files Changed" and look at the webpage above and let me know if you see anything that needs modifications.

  • Do these changes include sufficient documentation and testing updates? [No]

Redirection and documentation, including updating the Release Guide, will be done later.
dtcenter/METplus#836

  • Will this PR result in changes to the test suite? [No]

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METviewer 4.0 milestone Mar 9, 2021
@jprestop jprestop linked an issue Mar 9, 2021 that may be closed by this pull request
21 tasks
Copy link
Contributor

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changes as the ones for MET. And I double-checked the RTD docs and they look good. I approve.

Copy link
Contributor

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changes to enable RTD that Julie applied to the other METplus repos. I approve of these changes.

@jprestop jprestop merged commit 5cd0b4e into develop Mar 10, 2021
@jprestop jprestop deleted the feature_253_readthedocs branch March 10, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move documentation to Read the Docs
2 participants