Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_readthedocs_v3.0 #865

Merged
merged 5 commits into from
Apr 1, 2021
Merged

feature_readthedocs_v3.0 #865

merged 5 commits into from
Apr 1, 2021

Conversation

jprestop
Copy link
Collaborator

@jprestop jprestop commented Apr 1, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

Set up ReadTheDocs for METplus and verified everything looked good here:
https://metplus.readthedocs.io/en/feature_readthedocs_v3.0

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review the "Files Changed" and look at the webpage above and let me know if you see anything that needs modifications.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

Redirection and documentation, including updating the Release Guide, will be done later #836

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METplus-4.0.0 milestone Apr 1, 2021
@jprestop jprestop requested a review from georgemccabe April 1, 2021 17:34
@jprestop jprestop linked an issue Apr 1, 2021 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are similar to the PR for v3.1 (#864) with the addition of an ignore entry for the generated doc files and adding a requirements file for the repo. I approve.

@jprestop jprestop merged commit 664e7b5 into main_v3.0 Apr 1, 2021
@jprestop jprestop deleted the feature_readthedocs_v3.0 branch April 1, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the documentation over to Read The Docs
2 participants