Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 821 --> develop --> develop-ref #823

Merged
merged 100 commits into from
Mar 1, 2021
Merged

PR 821 --> develop --> develop-ref #823

merged 100 commits into from
Mar 1, 2021

Conversation

fentoad72
Copy link
Contributor

Pull Request Testing

  • Describe testing already performed for these changes:

    Prior to submitting the PR, tested CyclonePlotter_fcstGFS_obsGFS_OPC.conf (feature_728_newTCdata) with several different data files from the EMC data on several different dates. Requested that the cyclone points be connected by lines, so Minna changed this in CyclonePlotter.py and moved/resized the legend. 2020100700 is the sample date in the PR

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    EMC data for trak.gfso.atcf_gen.glbl.2020 has been uploaded. Other dates (besides 2020100700) could be checked against NCEP data (https://www.emc.ncep.noaa.gov/mmb/gplou/emchurr/glblgen/index.html)

  • Do these changes include sufficient documentation and testing updates? [Yes or No]
    Yes

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    Yes. CyclonePlotter_fcstGFS_obsGFS_OPC.conf is now included in internal tests

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

JohnHalleyGotway and others added 30 commits August 20, 2020 16:05
…hub.com/dtcenter, ncar.github.io with dtcenter.github.io, and rename METdb to METdatadb. (#575)
…utput if the wrapper is in the process list"

This reverts commit c99a9bf.
…ption

bugfix master v3.1 plotter exception
* Per #589, add script and Dockerfile to build images for all of the METplus sample data assets.

* Deleting old script

* Per #589, update the Docker data setup to explicitly define the mount point directory for each tarball so that you can mount multiple ones in a docker run command without them clobbering eachother.

* Per #589 and as discussed via Slack, consolidate the / down into just  that includes the source METplus version to avoid confusion with the current METplus version which is being used to create the Docker tag.

* Per #589, update the build_docker_images.sh script to accept the -push and -version command line options.
…rror message is shown if using a version of python that is before the requirement
…on_error

master v3.1 error message for old python version
* fixed formatted for use case doc

* removed duplicate glossary items that were causing a warning when building the docs
…sis_make_plots

bugfix 743 main_v3.1 StatAnalysis MakePlots always errors
…re_request.md template and changed the title. @TaraJensen will actually update the contents.
… this will prevent DockerHub failed builds and will allow us to remove the duplicate build rule for the old file locations. also removed travis yml file to prevent travis builds that now cost money to run (#746)
@georgemccabe georgemccabe merged commit 31a4d59 into develop-ref Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply TCPairs, TCStat, CyclonePlotter, GridStat to EMC 2020 Data
8 participants