Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix 743 main_v3.1 StatAnalysis MakePlots always errors #744

Merged

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Dec 22, 2020

bugfix per #743 - error will always be encountered when preparing for MakePlots run

Pull Request Testing

  • Describe testing already performed for these changes:

    Already tested by Mallory

  • Recommend testing for the reviewer to perform, including the location of input datasets:

    Make sure code change reflects change made locally

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • After merging, should the reviewer DELETE the feature branch from GitHub? [Yes]

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.

@georgemccabe georgemccabe added this to the METplus-3.1.1 Bugfix milestone Dec 22, 2020
@georgemccabe georgemccabe linked an issue Dec 22, 2020 that may be closed by this pull request
21 tasks
@malloryprow
Copy link
Contributor

Looks good!

@georgemccabe georgemccabe merged commit f27b19b into main_v3.1 Dec 22, 2020
@georgemccabe georgemccabe deleted the bugfix_743_main_v3.1_stat_analysis_make_plots branch December 22, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatAnalysis MakePlots is broken
2 participants