bugfix 730 main_v3.1 time_info corrupted

[georgemccabe]

The bug occurs when a time_info dictionary is passed back into time_util.ti_calculate. The function checks if init and valid are both set in the input dictionary. If so, it uses the loop_by value to determine which of them to delete from the dictionary so it will be recomputed. The call to del on the input dictionary deleted the 'valid' item from the input dictionary which is still used elsewhere in the code.

To fix in v3.1, copy input to ti_calculate into a new dictionary so that it can't be corrupted

Pull Request Testing

• Describe testing already performed for these changes:
  

• Ran the use case using main_v3.1 and confirmed a TypeError and crash occur:
  /d1/projects/METplus/METplus_Development/bugfix_time_info/METplus.main_v3.1/ush/master_metplus.py -c /d1/projects/METplus/METplus_Development/bugfix_time_info/metplus_final.conf
• Ran the case again using the fixed version to verify that although there are errors (data is not available), the case runs to completion.
  /d1/projects/METplus/METplus_Development/bugfix_time_info/METplus.main_v3.1_fix/ush/master_metplus.py -c /d1/projects/METplus/METplus_Development/bugfix_time_info/metplus_final.conf

• Recommend testing for the reviewer to perform, including the location of input datasets:
  

• Review the output on kiowa or rerun to verify that the change fixes the crash.

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• After merging, should the reviewer DELETE the feature branch from GitHub? [Yes]
  

Pull Request Checklist

See the METplus Workflow for details.

• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s), Project(s), and Milestone
• After submitting the PR, select Linked Issues with the original issue number.

[JohnHalleyGotway]

The problem description and fix make sense. I logged onto kiowa and ran the tests that George listed. I was able to replicate the problem and the fixed behavior that he described. I approve.