Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix 729 main_v3.1 fix SyntaxError use case doc #730

Merged

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Dec 10, 2020

Pull Request Testing

  • Describe testing already performed for these changes:

    Verified that the title for this use case is no longer SyntaxError:

dtcenter.github.io/METplus/latest/generated/model_applications/medium_range/TCStat_SeriesAnalysis_fcstGFS_obsGFS_FeatureRelative_SeriesByLead_PyEmbed_IVT.html#sphx-glr-generated-model-applications-medium-range-tcstat-seriesanalysis-fcstgfs-obsgfs-featurerelative-seriesbylead-pyembed-ivt-py

  • Recommend testing for the reviewer to perform, including the location of input datasets:

    Scan docs for anything incorrect/broken

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • After merging, should the reviewer DELETE the feature branch from GitHub? [Yes]

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.

@georgemccabe georgemccabe added this to the METplus-3.1.1 Bugfix milestone Dec 10, 2020
@georgemccabe georgemccabe linked an issue Dec 10, 2020 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I don't see any more syntax errors in the docs. And the changes are confined to documentation and comments.

@JohnHalleyGotway JohnHalleyGotway merged commit 114ec93 into main_v3.1 Dec 11, 2020
@JohnHalleyGotway JohnHalleyGotway deleted the bugfix_729_main_v3.1_use_case_doc_syntax_error branch December 11, 2020 17:06
@JohnHalleyGotway JohnHalleyGotway removed the request for review from TaraJensen December 11, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken use case documentation page for 3.1
2 participants