Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 681 quicksearch 3.1 #693

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Conversation

jprestop
Copy link
Collaborator

@jprestop jprestop commented Nov 4, 2020

Pull Request Testing

  • Describe testing already performed for these changes:

Clicked on the links on the page below and saw that the quick search did not work:
https://dtcenter.github.io/METplus/v3.1/Users_Guide/quicksearch.html

Fixed the problem and put it the fixes at a temporary web location. Clicked on the links on the page below and saw that the quick search now works:
https://ral.ucar.edu/staff/jpresto/work/METplus_jpresto/Users_Guide/quicksearch.html

  • Recommend testing for the reviewer to perform, including the location of input datasets:

Please repeat what I did above to verify.

  • Will this PR result in changes to the test suite? [Yes or No]

    No

  • After merging, should the reviewer DELETE the feature branch from GitHub? [Yes or No]

    Yes

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name. (Sorry I named the branch incorrectly, using feature instead of bugfix!)
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
    (I didn't link the issue because I don't want it to close after this is approved, because I still need to do it for the 3.1 documentation and need to update the release documentation, but that the release documentation will be updated in branch feature_673_release_guide.)

@jprestop jprestop added this to the METplus-3.1.1 Bugfix milestone Nov 4, 2020
@jprestop jprestop requested a review from georgemccabe November 4, 2020 19:58
@jprestop jprestop changed the title Fixed quick search links in quicksearch.rst Feature 681 quicksearch 3.1 Nov 4, 2020
Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changes as the previous PR but using v3.1 instead of develop. Looks good.

@georgemccabe georgemccabe merged commit e9a4406 into main_v3.1 Nov 5, 2020
@georgemccabe georgemccabe deleted the feature_687_quicksearch_3.1 branch November 5, 2020 00:08
@jprestop jprestop mentioned this pull request Nov 12, 2020
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants