Bugfix 589 master_v3.1 docker data #590
Conversation
…Tplus sample data assets.
… point directory for each tarball so that you can mount multiple ones in a docker run command without them clobbering eachother.
|
George, if/when we merge these changes, I'll make the same changes and submit a PR for develop. |
There was a problem hiding this comment.
This is great you were able to consolidate the Dockerfiles into one customizable file.
One comment regarding the same changes in develop: There are some changes I added in @fentoad72 's fork that involve consolidating the list of sample data tarball names into 1 file under ci/travis_jobs. The list in metplus_sample_data is mostly duplicated from this file. You can make the same changes in develop as you did for master_v3.1, but we should be sure to reconcile the two lists so that they is only one list to change.
… that includes the source METplus version to avoid confusion with the current METplus version which is being used to create the Docker tag.
…h and -version command line options.
|
I updated this PR to add a header block to the script and add -push/-version command line options to override the defaults. Also, read the metplus_sample_data file from the directory in which the script being run ($0) lives. That way you don't have to run the build_docker_images.sh from inside the directory in which it lives. Here's how you could run it and automatically push results to DockerHub: build_docker_images.sh -version 4.0 -push |
Please see this note describing the changes:
#589 (comment)
I ran the script, created the images, and pushed them to DockerHub here:https://hub.docker.com/repository/docker/dtcenter/metplus-data/tags?page=1