Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1534 main_v4.1 fix removal of semi-colon at end of list #1572

Merged
merged 7 commits into from
Apr 20, 2022

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Apr 18, 2022

Pull Request Testing

  • Describe testing already performed for these changes:

Added unit tests the demonstrate bug behavior, ran tests to ensure that they fail, then made fixes to get tests to pass.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review code changes, ensure that all automated tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    Just adding new unit tests that should pass

  • Please complete this pull request review by 2022/04/19.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplus-4.1.1 Bugfix milestone Apr 18, 2022
@georgemccabe georgemccabe changed the title per#1534, add unit test for properly adding a trailing semi-colon fo… Bugfix 1534 fix removal of semi-colon at end of list Apr 18, 2022
@georgemccabe georgemccabe changed the title Bugfix 1534 fix removal of semi-colon at end of list Bugfix 1534 main_v4.1 fix removal of semi-colon at end of list Apr 18, 2022
@georgemccabe georgemccabe linked an issue Apr 18, 2022 that may be closed by this pull request
23 tasks
@georgemccabe georgemccabe marked this pull request as ready for review April 18, 2022 17:39
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.
I reviewed the code changes and confirmed that all of the GHA tests passed.

@georgemccabe georgemccabe merged commit 17fa160 into main_v4.1 Apr 20, 2022
@georgemccabe georgemccabe deleted the bugfix_1535_main_v4.1_list_semicolon branch April 20, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Bugfix: Fix PCPCombine extra options removal of semi-colon
2 participants