Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for commonly changed MET config variables part 2 #896

Closed
21 of 34 tasks
georgemccabe opened this issue Apr 27, 2021 · 1 comment · Fixed by #1322
Closed
21 of 34 tasks

Add support for commonly changed MET config variables part 2 #896

georgemccabe opened this issue Apr 27, 2021 · 1 comment · Fixed by #1322
Assignees
@georgemccabe
Labels
component: python wrapper priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone
METplus-4.1.0

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Apr 27, 2021 •
edited
Loading

Continuation of #779 to keep progress completed for the issue associated with METplus 4.0.0 and associate the remaining tasks with 4.1.0.

Describe the Enhancement

From the original list @malloryprow provided, all of the MET config variables are supposed EXCEPT for the following:

GridStat:

  • fourier
  • censor_thresh
  • censor_val

PB2NC:

  • obs_prefbufr_map
  • obs_bufr_map

PointStat:

TCPairs:

  • check_dup
  • interp12
    Note: match_points is not configurable in the config file but it is an option in the wrapper which sets the command line argument which has the same behavior

SeriesAnalysis:

  • output_stats (only cts and cnt lists are currently supported)

MODE:

  • ps_plot_flag
  • ct_stats_flag

Time Estimate

~2-3 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

4.1.0

Funding Source

Split across open keys

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: python wrapper component: use case configuration priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office requestor: METplus Team METplus Development Team labels Apr 27, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Apr 27, 2021
@georgemccabe georgemccabe self-assigned this Apr 27, 2021
@georgemccabe georgemccabe mentioned this issue Apr 27, 2021
Closed
21 tasks
@TaraJensen TaraJensen added required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels May 17, 2021
@georgemccabe georgemccabe mentioned this issue Jul 26, 2021
Closed
20 tasks
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Aug 3, 2021
@georgemccabe georgemccabe mentioned this issue Aug 18, 2021
Closed
20 tasks
georgemccabe added a commit that referenced this issue Dec 7, 2021
@georgemccabe
per #896, added support for setting fourier dictionary in a GridStat …
2363fb9 
…MET config file
georgemccabe added a commit that referenced this issue Dec 7, 2021
@georgemccabe
per #896, added support for setting obs_bufr_map and obs_prepbufr_map…
b08dfaa 
… in the PB2NC MET config file
georgemccabe added a commit that referenced this issue Dec 15, 2021
@georgemccabe
per #896, added support for mask.llpnt in PointStat MET config
b0eb3c9
georgemccabe added a commit that referenced this issue Dec 15, 2021
@georgemccabe
per #896, added documentation for mask.llpnt and updated deprecated v…
2c18523 
…ariables
georgemccabe added a commit that referenced this issue Dec 15, 2021
@georgemccabe
per #896, add support for setting the hira dictionary in the PointSta…
f6d7b68 
…t wrapped MET config file
georgemccabe added a commit that referenced this issue Dec 15, 2021
@georgemccabe
per #896, added support for setting message_type_group_map in PointSt…
ea2387b 
…at wrapped MET config file
georgemccabe added a commit that referenced this issue Dec 15, 2021
@georgemccabe
per #896, add support for setting check_dup in TCPairs wrapped MET co…
12030c3 
…nfig file
georgemccabe added a commit that referenced this issue Dec 15, 2021
@georgemccabe
per #896, add support for setting check_dup in TCPairs wrapped MET co…
1a93cbe 
…nfig file and rearranged basic use case config files to be more readable
georgemccabe added a commit that referenced this issue Dec 16, 2021
@georgemccabe
per #896, add support for setting interp12 in TCPairs wrapped MET con…
2e5f4b6 
…fig file
georgemccabe added a commit that referenced this issue Dec 16, 2021
@georgemccabe
per #896, add support for setting all output_stats values in SeriesAn…
b01ac4d 
…alysis wrapped MET config file while preserving legacy setting of env vars for cts and cnt separately and using output_stats.cnt values to generate images, ci-run-all-diff
georgemccabe added a commit that referenced this issue Dec 16, 2021
@georgemccabe
per #896, add support for setting all output_stats values in SeriesAn…
15ee427 
…alysis wrapped MET config file and rearranged basic use case conf for readability, ci-run-all-diff
georgemccabe added a commit that referenced this issue Dec 16, 2021
@georgemccabe
per #896, add support for setting ps_plot_flag and ct_stats_flag in M…
3a40b14 
…ODE wrapped MET config file
georgemccabe added a commit that referenced this issue Dec 16, 2021
@georgemccabe
per #896, add support for setting censor_thresh and censor_val in Gri…
4481662 
…dStat wrapped MET config file, ci-run-all-diff
@georgemccabe georgemccabe mentioned this issue Dec 16, 2021
Merged
12 tasks
@georgemccabe georgemccabe linked a pull request Dec 16, 2021 that will close this issue
Feature 896 more met config #1322
Merged
12 tasks
@georgemccabe
Copy link
Collaborator Author

Closed via #1322

@TaraJensen TaraJensen added reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project reporting: DTC NOAA R2O NOAA Research to Operations DTC Project labels Jan 3, 2022
@georgemccabe georgemccabe changed the title Round 2 - Add support for commonly changed MET config variables Add support for commonly changed MET config variables part 2 Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgemccabe georgemccabe

Labels
component: python wrapper priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
None yet
Milestone
METplus-4.1.0
Development

Successfully merging a pull request may close this issue.

Feature 896 more met config dtcenter/METplus
3 participants
@jprestop @TaraJensen @georgemccabe