Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 2 fields with same name and different levels in SeriesBy cases #852

Closed
21 tasks done
georgemccabe opened this issue Mar 22, 2021 · 0 comments · Fixed by #868
Closed
21 tasks done

Add support for 2 fields with same name and different levels in SeriesBy cases #852

georgemccabe opened this issue Mar 22, 2021 · 0 comments · Fixed by #868
Assignees
Labels
METplus: Configuration priority: high High Priority requestor: NCAR National Center for Atmospheric Research requestor: University/other University Collaborator, not otherwise specified type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Mar 22, 2021

MET Help ticket 99154 brought to attention that the SeriesBy use cases currently can't handle 2 fields with the same name with different level values. The calls to RegridDataPlane in ExtractTiles wrapper fail because the same name is used for both fields. This can be remedied by setting FCST_REGRID_DATA_PLANE_VAR<n>_OUTPUT_NAME, however SeriesAnalysis still looks for fields with the original name.

Describe the Enhancement

Modify the logic to support multiple fields with the same name.

Time Estimate

~1-2 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

Ideally for the 4.0.0 release

Funding Source

2788881

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: use case configuration priority: high High Priority requestor: NCAR National Center for Atmospheric Research labels Mar 22, 2021
@georgemccabe georgemccabe added this to the METplus-4.0.0 milestone Mar 22, 2021
@georgemccabe georgemccabe self-assigned this Mar 22, 2021
@georgemccabe georgemccabe added the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Mar 30, 2021
@TaraJensen TaraJensen added requestor: University/other University Collaborator, not otherwise specified and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Mar 31, 2021
@georgemccabe georgemccabe linked a pull request Apr 12, 2021 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
METplus: Configuration priority: high High Priority requestor: NCAR National Center for Atmospheric Research requestor: University/other University Collaborator, not otherwise specified type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants