Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify code throughout METplus components that are common utilities #799

Closed
1 of 21 tasks
bikegeek opened this issue Feb 9, 2021 · 3 comments
Closed
1 of 21 tasks
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work

Comments

@bikegeek
Copy link
Contributor

bikegeek commented Feb 9, 2021

Replace italics below with details for this issue.

Describe the Task

There are potential utilities that can be used for METplus wrappers, METplotpy, METcalcpy, METdatadb, and/or METviewer. Collect potential common utilities.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the task down into sub-issues.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added type: task An actionable item of work alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team labels Feb 9, 2021
@georgemccabe
Copy link
Collaborator

georgemccabe commented Feb 9, 2021

Python scripts that would be useful for multiple projects:

  • Regression testing diffing scripts

@bikegeek bikegeek added this to the METplus Future Versions milestone Feb 9, 2021
@georgemccabe
Copy link
Collaborator

Breaking up metplus/util/met_util.py into multiple files with related functionality would make this easier. Here is the existing issue for that: #344

@TaraJensen TaraJensen added the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label May 17, 2021
@georgemccabe
Copy link
Collaborator

Some work has been done to move functions in metplus/util/met_util into other files that are specific to a given utility. The most likely candidate for a utility in the METplus repo that would be useful to other repositories is the diff_util that is used for comparing files in the automated tests. Other utilities such as string template substitution logic could potentially be useful but we do not currently have a specific need for that logic in other repos.

Closing this issue because the task was to identify common utilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Projects
None yet
Development

No branches or pull requests

3 participants