Refactor extract_tiles_wrapper #331
Comments
bikegeek
added
component: python wrapper
component: testing
…rectory that is the current process ID and remove existing tmp file before appending to it. This will prevent appending identical information (and headers) to the tmp file for a given storm, when re-running extract tiles with existing tc pairs output. This will result in an error as it is assumed that the tmp file will only have one header.
|
removed the creation of the tmp/ subdirectory in extract_tiles_wrapper.py. Also checking for pre-existing tmp file (before appending header and storm info) in feature_util.py (retrieve_and_regrid()). This check is needed to support the re-running of extract tiles wrapper, or when running the extract tiles wrapper using pre-existing tc pairs output. |
…s id 1) this will allow extract tiles to be run using the tc-pairs data from previous runs 2) check for the existence of a tmp file in the tmp directory that matches the storm of interest and delete it if it does. If you fail to do this, subsequent runs of extract tiles wrapper will append identical information (headers included) which result in errors later on when we are parsing these tmp files for information.
Break up the run_at_time() method into smaller methods so we can do proper unit testing.
…nger depends on process id. Merge branch 'feature_331_refactor_extract_tiles' into develop
|
extract tiles wrapper is now refactored so that it is unit-testable by breaking up the run_at_time() method to invoke other methods: Now the wrapper is unit-testable (refer to Github Issue #334 refactor extract tiles wrapper tests) and can be run/re-run using tc-pairs data from a different process. |
The extract tiles wrapper needs to be refactored so that 1) there are more methods than the run_at_time() method and 2) to not rely on a process id to differentiate one extract tile wrapper run from another. Issue #2 prevents the ability to use pre-existing data for unit testing. Currently, the only testing that can be performed is system (end-to-end) testing where the extract tiles wrapper must be run in order to check final output.
The text was updated successfully, but these errors were encountered: