Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ExtractTiles using MTD input to properly match times #1285

Closed
10 of 22 tasks
georgemccabe opened this issue Nov 23, 2021 · 0 comments · Fixed by #1315
Closed
10 of 22 tasks

Enhance ExtractTiles using MTD input to properly match times #1285

georgemccabe opened this issue Nov 23, 2021 · 0 comments · Fixed by #1315
Assignees
Labels
component: python wrapper MET: Object Verification Object-based feature Verification priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory requestor: NOAA/WPC NOAA Weather Prediction Center type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Nov 23, 2021

While developing a new feature relative use case, @hertneky discovered that the logic for ExtractTiles using MTD data to match fcst and obs objects assumes that the times slices match up 1-to-1 in order. However, this is not the case in some MTD output.

Describe the Enhancement

Modify the logic to loop through the times for either fcst or obs and find the corresponding time in the other. Only process if there is a time for both inputs. Also, skip the 000 clusters.

Also consider adding an option to filter which objects to use.

Time Estimate

~1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

Relevant Deadlines

4.1.0-beta5

Funding Source

2700042

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: python wrapper priority: high High Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: NCAR/RAL NCAR Research Applications Laboratory requestor: NOAA/WPC NOAA Weather Prediction Center MET: Object Verification Object-based feature Verification labels Nov 23, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Nov 23, 2021
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Nov 23, 2021
@georgemccabe georgemccabe linked a pull request Dec 14, 2021 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: python wrapper MET: Object Verification Object-based feature Verification priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory requestor: NOAA/WPC NOAA Weather Prediction Center type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants