Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_15_readthedocs #22

Merged
merged 2 commits into from
Mar 10, 2021
Merged

feature_15_readthedocs #22

merged 2 commits into from
Mar 10, 2021

Conversation

jprestop
Copy link
Contributor

Pull Request Testing

  • Describe testing already performed for these changes:

    Set up ReadTheDocs for MET and verified everything looked good here:
    https://metexpress.readthedocs.io/en/feature_15_readthedocs/

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the "Files Changed" and look at the webpage above and let me know if you see anything that needs modifications.
    I do not believe I have the authority to merge here, but I am not sure. Could you please also merge it?

  • Do these changes include sufficient documentation and testing updates? [No]
    Redirection and documentation, including updating the Release Guide, will be done later.
    ReadTheDocs: Set up gh-pages redirection and update Release Guide METplus#836

  • Will this PR result in changes to the test suite? [No]

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s) (there was no appropriate project for me to select), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METexpress 4.0.0 milestone Mar 10, 2021
@jprestop jprestop linked an issue Mar 10, 2021 that may be closed by this pull request
21 tasks
Copy link
Contributor

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the same changes that @jprestop has made to facilitate RTD in the other METplus repos. I approve of these changes.
Note that these settings PREVENT the publication of a PDF version. @ksearight is coordinating with Bonny of the formatting of the PDF.
@mollybsmith-noaa this merges the changes into the development branch. Recommend that you also merge them into the master (main) branch eventually.

@jprestop jprestop merged commit 8906868 into development Mar 10, 2021
@jprestop jprestop deleted the feature_15_readthedocs branch March 10, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the documentation over to Read The Docs
2 participants