Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #99 update versions #100

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

bikegeek
Copy link
Contributor

Pull Request Testing

  • Describe testing already performed for these changes:

    Verify no warnings from GHA

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

For the following files:
build.yml codeql-analysis.yml documentation.yml trivy-repo-analysis.yml

verify that version numbers updated (wherever applicable):
- Update version of actions/checkout to v3
- Update version of actions/setup-python to v4
- Update version of actions/upload-artifact to v3
- Update version of actions/download-artifact to v3
- Update version of actions/github-script to v6

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [NA]

  • Will this PR result in changes to the test suite? [ No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [earliest convenience to meet beta4 deadline].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@mollybsmith-noaa mollybsmith-noaa merged commit 6d8ccc4 into development Oct 20, 2022
@mollybsmith-noaa mollybsmith-noaa deleted the feature_99_gha_warnings branch October 20, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants