Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #3037 v12.1.0-beta1 #3062

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Jan 24, 2025

Expected Differences

Note that there are 1,000 files modified only because I changed the copyright year from 2024 to 2025. Note that the testing workflow will flag some diffs because of a recent PR for which the truth dataset has not yet been updated. All I really need here is a review of the release notes.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Built and review the release notes locally on my laptop.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Please review the beta1 release notes for this PR on RTD at this link:
https://met--3062.org.readthedocs.build/en/3062/Users_Guide/release-notes.html#met-version-12-1-0-beta1-release-notes-20250124

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]
    None needed.

  • Will this PR result in changes to the MET test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:
    No actual code changes here - only docs and source code comments.

  • Please complete this pull request review by [Fri 1/24/25].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.1.0 milestone Jan 24, 2025
@JohnHalleyGotway JohnHalleyGotway marked this pull request as ready for review January 24, 2025 19:10
@jprestop
Copy link
Collaborator

@JohnHalleyGotway
I see there was an error in the Check for Differences:

**************
ERROR SUMMARY:
**************

dir1: /data/output/met_test_truth contains 1177 files
dir2: /data/output/met_test_output contains 1178 files

ERROR: folder /data/output/met_test_truth missing 1 files
    point_stat_ugrid/point_stat_UGRID_LFRIC_PRESSURE_LEVELS_180000L_20120409_180000V.stat 

End of script
ERROR: Differences exist in the output
Error: Process completed with exit code 1.

Is the addition of this new file expected in this PR?

@JohnHalleyGotway
Copy link
Collaborator Author

@jprestop, yes, that difference is expected due to a separate PR and develop-ref is currently being updated to move past it. I just pushed changes to update the structure of the upgrade instructions section. While you review this updated structure, I'll work on adding content for this beta1 release.

jprestop
jprestop previously approved these changes Jan 24, 2025
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this and for the modifications! I like the changes you made i the upgrade instructions section. Thanks! I approve this request.

@jprestop
Copy link
Collaborator

I reviewed the content you added and fixed up a bulleted list. I think we're good to go.

@JohnHalleyGotway JohnHalleyGotway merged commit 349600f into develop Jan 24, 2025
29 checks passed
@JohnHalleyGotway JohnHalleyGotway linked an issue Jan 24, 2025 that may be closed by this pull request
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Create the MET-12.1.0 Beta1 Development Release
2 participants