-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #3037 v12.1.0-beta1 #3062
Conversation
@JohnHalleyGotway
Is the addition of this new file expected in this PR? |
…de instructions
@jprestop, yes, that difference is expected due to a separate PR and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this and for the modifications! I like the changes you made i the upgrade instructions section. Thanks! I approve this request.
I reviewed the content you added and fixed up a bulleted list. I think we're good to go. |
Expected Differences
Note that there are 1,000 files modified only because I changed the copyright year from 2024 to 2025. Note that the testing workflow will flag some diffs because of a recent PR for which the truth dataset has not yet been updated. All I really need here is a review of the release notes.
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Built and review the release notes locally on my laptop.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please review the beta1 release notes for this PR on RTD at this link:
https://met--3062.org.readthedocs.build/en/3062/Users_Guide/release-notes.html#met-version-12-1-0-beta1-release-notes-20250124
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
None needed.
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
No actual code changes here - only docs and source code comments.
Please complete this pull request review by [Fri 1/24/25].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases