Code

Feature #1019 USCRN #3049

Code

Merged

JohnHalleyGotway merged 25 commits intodevelopdtcenter/MET:developfrom feature_1019_USCRNdtcenter/MET:feature_1019_USCRNCopy head branch name to clipboardJan 22, 2025

+1,379-553

Commits

Commits on Jan 7, 2025

• Per #1019, initial setup for supporting -format uscrn. It compiles but I still need to make it work for the variety of USCRN inputs.

  JohnHalleyGotway

  committed
  30bf0b7

  Copy full SHA for 30bf0b7

• Per #1019, add NumArray constructor using a vector of doubles.

  JohnHalleyGotway

  committed
  834b5d7

  Copy full SHA for 834b5d7

• Per #1019, saving progress after handling monthly, daily, and hourly input files. Need to complete support for other format types and handle the unit strings

  JohnHalleyGotway

  committed
  df6211a

  Copy full SHA for df6211a

Commits on Jan 10, 2025

• Per #1019, consistent spacing.

  JohnHalleyGotway

  committed
  ea54503

  Copy full SHA for ea54503

• Per #1019, tweak log messages so that the file being read is logged before it's actually read so that an error in parsing the data will indicate which file caused it.

  JohnHalleyGotway

  committed
  a9530a1

  Copy full SHA for a9530a1

• Per #1019, update DataLine and LineDataFile classes to support parsing .csv files. Get rid of the unneeded Offsets vector. Add AllowEmptyColumns option to the DataLine class so that multiple delimi…

  Show description for 64a6f23
  JohnHalleyGotway

  committed
  64a6f23

  Copy full SHA for 64a6f23

• Per #1019, update USCRN handler code to support all 7 input variants, including .csv files. This required updates to the DataLine and LineDataFile classes to parse the .csv data properly. Still nee…

  Show description for 0ebace0
  JohnHalleyGotway

  committed
  0ebace0

  Copy full SHA for 0ebace0

Commits on Jan 11, 2025

• Per #1019, add units to the Observation class.

  JohnHalleyGotway

  committed
  4674e98

  Copy full SHA for 4674e98

• Per #1019, add units string to the SummaryObs and SummaryKey classes.

  JohnHalleyGotway

  committed
  285804b

  Copy full SHA for 285804b

• Per #1019, update USCRN format to write units. Consider defining units for all the other ascii file types as well.

  JohnHalleyGotway

  committed
  302e4d5

  Copy full SHA for 302e4d5

Commits on Jan 13, 2025

• Per #1019, add StringArray::all_empty() member function to check for a list of all empty strings. This is used in ascii2nc to determine if observation units and descriptions should be written.

  JohnHalleyGotway

  committed
  ef4d982

  Copy full SHA for ef4d982

• Per #1019, update library code to handle the independent writing of point observation descriptions. Previously, if units were present then descriptions (usually empty ones) were added. Now, units a…

  Show description for 6202314
  JohnHalleyGotway

  committed
  6202314

  Copy full SHA for 6202314

• Per #1019, add descriptions for all USCRN observations, pulled from the USCRN website.

  JohnHalleyGotway

  committed
  07dd0a8

  Copy full SHA for 07dd0a8

• Merge remote-tracking branch 'origin/develop' into feature_1019_USCRN

  JohnHalleyGotway

  committed
  8f5bedc

  Copy full SHA for 8f5bedc

• Per #1019, need to subtract 1900 from the year and 1 from the month to make this work. Seems like we should ADD these numbers where needed rather than subtracting them everywhere else!

  JohnHalleyGotway

  committed
  add3aef

  Copy full SHA for add3aef

• Per #1019, get rid of USCRNHandler::_readHeaderInfo() since it compilicated the logic for ignoring the first line from csv files.

  JohnHalleyGotway

  committed
  a92047f

  Copy full SHA for a92047f

• Per #1019, rather than always skipping the first line of USCRN csv files, just skip any lines where the station ID begins with 'WBAN'. That'll handle files being concatenated together and is simple…

  Show description for 4012a65
  JohnHalleyGotway

  committed
  4012a65

  Copy full SHA for 4012a65

• Per #1019, add an ascii2nc unit test for USCRN point observations.

  JohnHalleyGotway

  committed
  aa1be48

  Copy full SHA for aa1be48

• Per #1019, doc-only change to indicate the prefix/suffix of the input USCRN files are used to the determine the specific format.

  JohnHalleyGotway

  committed
  e38af93

  Copy full SHA for e38af93

Commits on Jan 14, 2025

• Per #1019, update USCRN code to no longer specify a default _qcOffset value since it conflicts with the initialization. While the GHA compiler is fine with it, the SonarQube one is not. These chang…

  Show description for d04d83e
  JohnHalleyGotway

  committed
  d04d83e

  Copy full SHA for d04d83e

• Per #1019, for SonarQube replace ALL instances of push_back() with emplace_back() which SonarQube prefers for efficiency.

  JohnHalleyGotway

  committed
  c02f1c9

  Copy full SHA for c02f1c9

• Per #1019, more changes to address SonarQube code smells and reduce the overall number of them lower than what's in the develop branch.

  JohnHalleyGotway

  committed
  8a9b02a

  Copy full SHA for 8a9b02a

Commits on Jan 15, 2025

• Per #1019, second pass through to further reduce SonarQube findings.

  JohnHalleyGotway

  committed
  65dd8ec

  Copy full SHA for 65dd8ec

• Per #1019, revert back to protected members in file_handler.h

  JohnHalleyGotway

  committed
  de71c6d

  Copy full SHA for de71c6d

• Per #1019, one last round of minor SonarQube code smell remediation.

  JohnHalleyGotway

  committed
  aca605b

  Copy full SHA for aca605b