Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2471 v12.0.0_beta2 #2744

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Nov 17, 2023

Expected Differences

Adds MET-12.0.0-beta2 release notes.
Fixes Wavelet-Stat '2^n x 2^n' equations.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Built locally to confirm Wavelet-Stat fix.
    From:
    Screen Shot 2023-11-17 at 2 11 28 PM
    To:
    Screen Shot 2023-11-17 at 2 12 37 PM

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please review these proposed MET-12.0.0-beta2 release notes on RTD and updated Wavelet-Stat equations.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    Just release notes.

  • Do these changes include sufficient testing updates? [Yes]
    No new tests needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

    Note that differences WILL be flagged by the GHA run, but these originate from recently committed PR's. We need to update the develop-ref branch to get past those diffs.

  • Please complete this pull request review by [Fri 11/17/23].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Nov 17, 2023
@JohnHalleyGotway JohnHalleyGotway linked an issue Nov 17, 2023 that may be closed by this pull request
20 tasks
@JohnHalleyGotway JohnHalleyGotway changed the base branch from main_v11.1 to develop November 17, 2023 20:54
… Wavelet-Stat. I removed the 'mathbf' option to eliminate the bolding. I searched through the MET docs and found that about 20% of the time we bold equations and the other 80% of the time we do not.
Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beta2 release notes were reviewed and no cause for changes were found. Equation in WaveletStat documentation now appears as expected. The PR is approved for merging.

@JohnHalleyGotway JohnHalleyGotway merged commit 1e52421 into develop Nov 17, 2023
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2471_v12.0.0-beta2 branch November 17, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Create the MET-12.0.0-beta2 release
2 participants