Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature main v11.0 update install files #2626

Merged
merged 5 commits into from
Jul 26, 2023

Conversation

jprestop
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Installed MET on various machines and loaded these modulefiles. They are checked into the repo as a backup and a record.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Ensure tests pass. Review files, if desired.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [When it is convenient, prior to the release; should be quick].

Pull Request Checklist

See the METplus Workflow for details.

  • [No issue] Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • [No issue] After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the MET 11.0.3 (bugfix) milestone Jul 25, 2023
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jprestop I see that these files update to compiling MET version 11.0.1. The most recent version is 11.0.2: https://github.com/dtcenter/MET/releases/tag/v11.0.2

I approve of these changes, as long as you're aware of 11.0.2 and confirm that you want to use 11.0.1 in these files rather than 11.0.2.

@jprestop
Copy link
Collaborator Author

@JohnHalleyGotway Thanks for catching that. It's totally fine to have 11.0.1 in the files as these are just a backup of what exist on the machine. I'm not sure if I had updated all of them, but the important information is there (paths, etc.) regardles of the version. Thanks for checking. I think it's fine to proceed.

@jprestop jprestop merged commit 9049b37 into main_v11.0 Jul 26, 2023
@jprestop jprestop deleted the feature_main_v11.0_update_install_files branch July 26, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants